Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated list of magnetic field steppers and EM physlists for Geant4 10.4 #22073

Merged
merged 5 commits into from Feb 5, 2018

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 1, 2018

These modifications are recommended by Geant4 experts for the version 10.4. None of those should affect current results, because the default configuration is not changed. This PR includes:

  1. addition of optional magnetic field steppers provided by Geant4 team. If enabled this may allow speed-up of FullSim. Two old obsolete steppers are removed from the list.
  2. More optimal configuration of CMS custom EM physics constructors, may be result as a tiny optimisation of CPU/memory

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Feb 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25846/console Started: 2018/02/01 17:37
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25847/console Started: 2018/02/01 17:40

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/MagneticField
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @namapane this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22073/25847/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22073/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.13999999993 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Feb 2, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Feb 2, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25858/console Started: 2018/02/02 09:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Pull request #22073 was updated. @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22073/25858/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22073/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.11999999992 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 3, 2018

@civanch as far as I can see the default stepper is unchanged. What about the changes in the physics lists? What should be the effect?

@civanch
Copy link
Contributor Author

civanch commented Feb 3, 2018

@fabiocos , I have checked, that these modifications do not change results - random number sequence not changed. These minor changes means do not instantiate objects, which are not used and skip some calls to these objects.

@fabiocos
Copy link
Contributor

fabiocos commented Feb 5, 2018

+1

@cmsbuild cmsbuild merged commit 5ea513c into cms-sw:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants