[HCAL] Make sure that trigger towers with abs(ieta)=16 are processed with QIE8 settings in 2018.

[matz-e]

Fixes a crash when only the last depth of tower 16 is present.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22077/3204

[cmsbuild]

A new Pull Request was created by @matz-e (Matthias Wolf) for master.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25850/console Started: 2018/02/01 18:48

[cmsbuild]

+1
Tested at: 4301bd1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22077/25850/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22077/25850/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22077/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465593
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.12000000005 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[deguio]

Hi @matz-e
is this relevant for 10_0_X and MC production?
thanks.

@christopheralanwest @hatakeyamak @mariadalfonso

[matz-e]

in principle, I think, yes. But I also think that the likelihood of triggering the bug being fixed is quite small.

The bug requires energy deposits/data frames in depth 4 of tower 16 and no energy/data frames for depths 1-3. My guess is that this would mainly occur (with a very small probability — basically energy leaking from 17 -> 16) when using the emulation from RAW with zero-suppression, and as such the the regular simulation chain should not really be impacted.

Do you want me to file a backport PR for 10_0_X?

[deguio]

Hi,
maybe electronic noise in simulation can also trigger the problem?

to be on the safe side I would backport to 10_0_X. we don't want to have unexpected crashes when the MC is submitted.

thanks,
F.

@fabiocos

[christopheralanwest]

@deguio Another motivation for the backport is the online and offline DQM. The crash could be triggered by tests in which the laser is fired into the HEM or HEP megatiles in a global run. Such tests are often done to validate the latency of TPs sent to L1.

[fabiocos]

@thomreis @rekovic could you please check?

[fabiocos]

@thomreis @rekovic could you please check? If we need this in 10_0_X it should be integrated asap. For what I can see the code looks reasonable, but I would like an expert to cross check.

[nsmith-]

IMHO these packages could be under HCAL signature and not L1: the interface between calorimeter and trigger responsibility is at the trigger primitive level, both in hardware and software. This change won't affect that interface. As the expert on the downstream consumer of these trigger primitives,
+1

[thomreis]

+1

The right way around.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1