Only HCAL HT versions 0 and 1 should be considered valid

[christopheralanwest]

Only HCAL HT trigger channel versions 0 and 1 should be considered valid. Currently versions 1 to 7 are considered equivalent, which could lead to problems if a version 2 is ever introduced.

This PR should have no effect on any standard workflow. The only effect expected is that the hardcoded conditions, which are also used to generate database input files (i.e. with [1]), will now be generated with the correct version number for HT channels corresponding to HF (version 1 rather than 7). The correct behavior of this PR has been verified for with [1].

[1] cmsRun $CMSSW_RELEASE_BASE/src/CondTools/Hcal/test/runDumpHcalCond_cfg.py dumplist="LutMetadata" usehardcode=True run=999999 geometry=Extended2018

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22096/3225

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Geometry/CaloTopology

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25897/console Started: 2018/02/05 09:50

[cmsbuild]

+1
Tested at: da99a6c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22096/25897/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22096/25897/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22096/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465593
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.12000000011 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1