Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing setters to CSCALCTDigi and CSCCLCTDigi #22099

Merged
merged 1 commit into from Feb 6, 2018
Merged

Add missing setters to CSCALCTDigi and CSCCLCTDigi #22099

merged 1 commit into from Feb 6, 2018

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Feb 2, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Feb 2, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25880/console Started: 2018/02/02 20:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22099/25880/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22099/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.910000000149 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor

civanch commented Feb 5, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2018

+1

@cmsbuild cmsbuild merged commit d11bc59 into cms-sw:master Feb 6, 2018
@dildick dildick deleted the from-CMSSW_10_1_X_2018-02-02-1100-ALCT-CLCT-missing-setters branch February 12, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants