Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates to CMSSW that are not directly related to GPU development (10.1.x) #22108

Merged
merged 1 commit into from Feb 7, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 4, 2018

We are pushing to this branches the fixes and improvements to the CMSSW code that we are making during the development of the GPU algorithms, but are not GPU specific.

Various improvements to pixel-related modules

  • mark PixelDigi constructor as explicit
  • improve SiPixelGainCalibrationOffline::getPed exception error message

  - mark `PixelDigi` constructor as `explicit`
  - improve `SiPixelGainCalibrationOffline::getPed` exception error message
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 4, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 4, 2018

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25893/console Started: 2018/02/04 22:15

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CondFormats/SiPixelObjects
DataFormats/SiPixelDigi

@ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @rovere, @VinInn, @dkotlins, @tocheng, @mmusich, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22108/25893/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22108/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.940000000177 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@ghellwig
Copy link

ghellwig commented Feb 5, 2018

+1

@civanch
Copy link
Contributor

civanch commented Feb 5, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 7, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2018

+1

@cmsbuild cmsbuild merged commit f616a37 into cms-sw:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants