Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL DQM: online config changes for 2018 #22109

Merged
merged 3 commits into from
Feb 6, 2018

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Feb 5, 2018

Some basic changes to the configurations for HCAL online DQM: change eras to 2018, remove plan-1-specific things.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25905/console Started: 2018/02/05 17:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22109/25905/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22109/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.12000000002 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2018

+1

@cmsbuild cmsbuild merged commit 8e02339 into cms-sw:master Feb 6, 2018
cmsbuild added a commit that referenced this pull request Feb 6, 2018
HCAL DQM: online config changes for 2018 (10_0_X version of #22109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants