Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around clang-tidy multi-line YAML issues (10.0.x backport) #22113

Merged
merged 1 commit into from Feb 12, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 5, 2018

It seems that clang-tidy does not properly parse multi-line strings, leaving the newline character as part of the string.
This commit wraps all options in commas, leaving the newlines outside of the names.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 5, 2018

type bugfix

@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Feb 5, 2018
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 5, 2018

backport #22112

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_0_X.

It involves the following packages:

.clang-tidy

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 5, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25899/console Started: 2018/02/05 14:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22113/25899/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22113/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468603
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.15000000001 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@Dr15Jones
Copy link
Contributor

@smuzaffar please review

@smuzaffar
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d37a4f7 into cms-sw:CMSSW_10_0_X Feb 12, 2018
@fwyzard fwyzard deleted the fix_clang-tidy_100x branch February 16, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants