EMTF patch for DQM quality test time-out issue

[abrinke1]

Follow up to PR #21812

Fix for Noisy Channel test causing time-out issues, described here:
#22008

"runTheMatrix.py -l 4.28 -i all" now takes 12 minutes on lxplus, single-threaded.

Replaces GetBinContents with integrals and adds TH2 passing to class. Based off branch from @chadfreer here:
https://github.com/chadfreer/cmssw/tree/Noisy_fix/

@fabiocos , @smuzaffar , @davidlange6 , @thomreis please take a look and test.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22114/3243

[cmsbuild]

A new Pull Request was created by @abrinke1 for master.

It involves the following packages:

DQMServices/Core

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25901/console Started: 2018/02/05 15:06

[cmsbuild]

+1
Tested at: e099885
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22114/25901/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22114/25901/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22114/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465590
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.88000000015 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[thomreis]

@dmitrijus @jfernan2 please take a look at this PR. It should fix the timeout issue with the 4.28 WF.

[fabiocos]

please test workflow 4.28

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25910/console Started: 2018/02/05 22:18

[cmsbuild]

+1
Tested at: e099885
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22114/25910/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22114/25910/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22114/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22114/4.28_HighMet2011A+HighMet2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465590
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.700000000157 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[thomreis]

Hi @abrinke1 can you please make a backport to 10_0_X so that we can test it in MWGR#3?

[abrinke1]

Hi @thomreis
It's not just the patch that would need to be back-ported, but the whole previous QT PR.
Do you know whether PR #21812 is already included in the stack of modifications at P5?

[thomreis]

Hi @abrinke1
as I have commented for #21812 it needs to be backported as well. Non of the two is at P5 at the moment.

[thomreis]

Hi @abrinke1 you can also merge these two PRs into one backport to 10_0_X. That would make it easier for the deployment at P5.

[abrinke1]

@thomreis please see PR #22189