CSC DQM CSCMonitorModule fix for missing histo labels (10_0_X backport) #22119
Conversation
|
A new Pull Request was created by @barvic (Victor Barashko) for CMSSW_10_0_X. It involves the following packages: DQM/CSCMonitorModule @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -156,8 +156,7 @@ namespace cscdqm { | |||
| const XMLCh *content = element->getTextContent(); | |||
| XERCES_CPP_NAMESPACE_QUALIFIER TranscodeToStr tc(content, "UTF-8"); | |||
| std::istringstream buffer((const char*)tc.str()); | |||
| std::string value; | |||
| buffer >> value; | |||
| std::string value = buffer.str(); | |||
There was a problem hiding this comment.
question: why?
Or why not just do std::string value((const char*)tc.str()); and skip buffer entirely?
There was a problem hiding this comment.
Just minimal fix to have working code again, until I figure out how it was actually producing expected output before (which is a real question for me).
Or why not just do std::string value((const char*)tc.str()); and skip buffer entirely?
Should work as well in this case
There was a problem hiding this comment.
@dmitrijus Now I think I figured it out.
It looks like the following commit on May 27, 2016 from central, related to UTF-8 handling, introduced this issue.
75ebcf5#diff-1d119251269edd210e26561f4a3b2dbd
|
+1 |
Backport to 10_0_X of PR #21976
CSC DQM CSCMonitorModule fix for missing histo labels in recent CMSSW/DQM releases