Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dE/dx hit association index #22124

Merged
merged 1 commit into from Feb 10, 2018
Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Feb 6, 2018

Fix issue in dE/dx hit association, as reported in https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3586/1/1/1.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

@gpetruc
Copy link
Contributor Author

gpetruc commented Feb 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22124/25915/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22124/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.11999999997 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Feb 7, 2018

+1

for #22124 9236c8e

  • the bugfix looks appropriate
  • jenkins tests pass; the comparisons show no differences as expected (recoDeDxHitInfosedmAssociation_isolatedTracks is not monitored)

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 675d4fd into cms-sw:master Feb 10, 2018
@gpetruc gpetruc deleted the miniAOD_fixDeDx_10X branch March 8, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants