[10.1.X] Add leftout parameters for FedChannelDigis

[mmusich]

Greetings,
in recent releases SiStripRawToDigiModule expects to be configured for:

• LegacyUnpacker :

  cmssw/EventFilter/SiStripRawToDigi/plugins/SiStripRawToDigiModule.cc

  Line 37 in 137e701

  bool legacy_unpacker = pset.getParameter<bool>("LegacyUnpacker");

• DoAPVEmulatorCheck :

  cmssw/EventFilter/SiStripRawToDigi/plugins/SiStripRawToDigiModule.cc

  Line 48 in 137e701

  doAPVEmulatorCheck_ = pset.getParameter<bool>("DoAPVEmulatorCheck");

Both of those parameters have no default and are not defined in EventFilter/SiStripRawToDigi/python/FedChannelDigis_cfi.py, giving issues at runtime when trying to reconstruct events from the Cosmic Rack (see details here).
To solve this issue, I've copied the value of those parameters from EventFilter/SiStripRawToDigi/python/SiStripDigis_cfi.py

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22141/3269

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ebrondol, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25938/console Started: 2018/02/07 13:21

[cmsbuild]

+1
Tested at: 0aac55d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22141/25938/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22141/25938/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22141/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2466491
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2466321
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.09000000003 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[perrotta]

@OlivierBondu : FedChannelDigis_cfi is only used by the DQM for SiStripCommissioning
Could you please confirm that the values of the parameters choosen by @mmusich are the one needed for it?

[OlivierBondu]

@perrotta : the values look correct to me, yes. On the other hand IIUC this shouldn't break anything but would help a great deal to have the cosmic rack running

[perrotta]

Thank you Olivier. It was clear that it doesn't break anything (it fixes that config, in fact): but since we had to assign some new parameter to the config, I just wanted to check that such values were the one endorsed by SiStrip DPG Olivier Bondu <notifications@github.com> ha scritto:

…

@perrotta : the values look correct to me, yes. On the other hand IIUC this shouldn't break anything but would help a great deal to have the cosmic rack running -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #22141 (comment)

[perrotta]

+1

• Configuration fixed by adding two missing parameters
• The inserted values are the ones requested by the SiStrip DPG

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1