Protect against reading invalid prescales #22156
Conversation
Avoid reading beyond the end of the vector. Problem was found by address sanitizer.
|
The code-checks are being triggered in jenkins. |
|
This fixes problems seen in the ASAN IB RelVals. E.g. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22156/3290 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: L1Trigger/L1TGlobal @nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
@fabiocos didn’t this pass all the tests already? |
|
@Dr15Jones it ran indeed, I see anyway more than thousand histos are different, and this test picked other PR for what I see. Looking randomly at the differences the histos seem essentially identical... |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@fabiocos the original code was creating objects using random memory (actually reading parts of the next object in the container or whatever was off the end of the container). If any later code made decisions based on those random values, I'd definitely expect differences. |
|
@Dr15Jones thanks for the clarification. In the last test apparently no difference, may be just good luck? I merge the fix. |
|
+1 |
Avoid reading beyond the end of the vector.
Problem was found by address sanitizer.