Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of external cms_oracleocci_abi_hack #22170

Merged
merged 1 commit into from Feb 10, 2018
Merged

make use of external cms_oracleocci_abi_hack #22170

merged 1 commit into from Feb 10, 2018

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Feb 9, 2018

This PR updates the unit test to make use of new cms_oracleocci_abi_hack external tool instead of local implementation of std::string

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

OnlineDB/Oracle

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Feb 9, 2018

please test with cms-sw/cmsdist#3730

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3730
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25998/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22170/25998/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22170/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2464162
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2463992
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.849999999802 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@smuzaffar smuzaffar merged commit 142a8f0 into cms-sw:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants