Fix bug affecting SubProcesses and multithreading #22186
Conversation
SubProcesses should and do have eventSetupForInstance called from the EventProcessor via the EventSetupsController. This fix removes the old call from the SubProcess class which should have been removed and creates data races when multiple streams are running.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22186/3336 |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
tests-pending
and removed
core-pending
pending-signatures
tests-started
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
SubProcesses should and do have eventSetupForInstance
called from the EventProcessor via the EventSetupsController.
This fix removes the old call from the SubProcess class
which should have been removed and creates data races when
multiple streams are running.