Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DQMEDAnalyzers from stream to one modules #22218

Merged
merged 2 commits into from Feb 20, 2018

Commits on Feb 16, 2018

  1. Migrate DQMEDAnalyzers from stream to one modules

    Migrate all DQMEDAnalyzer modules from `edm::stream::EDAnalyzer<...>` to
    `edm::one::EDAnalyzer<...>`.
    
    This should significantly reduce the memory usage of a multithreaded DQM
    job, at the price of preventing the framework from analysing multiple
    runs or lumisections at the same time.
    
    Lumisection-based histograms are handled in the `endLuminosityBlockProduce`
    method - which is only avaibale after the migration to `edm::one::EDProducer`.
    
    For the time being, lumisection-based histograms are broken. If a
    workaround is needed, one could use the `postModuleGlobalEndLumi` signal
    of the `DQMStore` directly.
    fwyzard committed Feb 16, 2018
    Copy the full SHA
    a3159bb View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. Handle lumisection-based histograms in the DQMStore

    For the time being, lumisection-based histograms are cloned and set with
    the correct lumisection index in the `postModuleGlobalEndLumi` signal
    handler of the `DQMStore`.
    
    If/when the `DQMEDAnalyzer` modules are migrated from `EDAnalyzer` to
    `EDProducer<Accumulator>`, the call should be moved to the modules'
    `endLuminosityBlockProduce` method.
    fwyzard committed Feb 20, 2018
    Copy the full SHA
    5fe910b View commit details
    Browse the repository at this point in the history