Fix testRandomService.sh unit test

[makortel]

If the multistream test doesn't run any event on stream 2, the file StashStateStream.data_2 is not created. The logic in the test script looks like it should fall back to StashStateStream.data_1 (and ..._0), but the subsequent tests are done agains StashStateFork.data_1 (and ..._0). This PR fixes the unit test by replacing all StashStateFork with StashStateStream. I tested that the fix works by manually removing the ..._2/1/0 files (within the script).

I can only wonder why we haven't seen this case before the PR tests #22069 (where it has failed twice; or maybe we have seen it and it has just been though transient and ignored).

Tested in CMSSW_10_1_X_2018-02-08-2300, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22231/3379

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

IOMC/RandomEngine

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26084/console Started: 2018/02/15 10:30

[cmsbuild]

+1
Tested at: 65c73e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22231/26084/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22231/26084/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.05999999982 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[Dr15Jones]

@wddgit please take a look.

[wddgit]

This bug fix looks good. The problem was a bug in the test that I put in back in 2013 when I converted the service to support multithreading. Probably I made a mistake when I cut and pasted some test code used for the forking case and did not modify it properly for the multithreading case. The bug was only hit when stream 2 did not process any events. I suppose we never noticed because that did not happen often. It must have been almost never, because I do not remember seeing this unit test ever fail. I'm not sure why stream 2 was not getting events in the new PR test ... Thanks for fixing the bug.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1