Fixed bug in CTPPSDiamondRecHitProducer

[nminafra]

Fixing of a bug introduced with PR #21426. The inversion of two lines gives an Out Of Time Index == 0 for all the rechits.
The testing procedure missed this because the OOTIndex is expected to be always 0 for run > 302159 and it gives "reasonable" values also for previous run.

@forthommel @fabferro

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22236/3386

[cmsbuild]

A new Pull Request was created by @nminafra (Nicola Minafra) for master.

It involves the following packages:

RecoCTPPS/TotemRPLocal

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26101/console Started: 2018/02/15 16:52

[perrotta]

@nminafra : please write "CTPPSDiamondRecHitProducer" in the title. instead than a more generic "RecHitProducer"

[nminafra]

@perrotta good point! Sorry!

[cmsbuild]

+1
Tested at: 3a5a1b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22236/26101/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22236/26101/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.769999999808 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[perrotta]

+1

• With this fix the order of the parameters fed to CTPPSDiamondRecHit coincides with what the constructor does expect

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1