New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if ZS of FR #22253
Conversation
…eInPath Backport, Modify FileInPath to not lookup file in edmWriteConfigs
…d obsolete code cleaning.
Restoring egamma DQM sequence for allForPrompt (100X)
…ix4-100X Fixes for conddb tools
A new Pull Request was created by @amassiro (Andrea Massironi) for master. It involves the following packages: CalibTracker/SiStripESProducers @ghellwig, @ianna, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @thomreis, @vanbesien, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @kpedro88, @slava77, @ggovi, @fabiocos, @nsmith-, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 |
-1 it looks like a wrong branch |
Sorry, I confirm wrong branch! |
Your PR is unmergeable. Please have a look and possibly rebase it. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22253/3441 |
Pull request #22253 was updated. @ghellwig, @ianna, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @thomreis, @vanbesien, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @kpedro88, @slava77, @ggovi, @fabiocos, @nsmith-, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @lpernie can you please check and sign again. |
-1 |
-1 |
Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if they have been read in Zero Suppression (ZS) of Full Readout (FR).
In the previous version we could activate these thresholds only in ZS regions, or de-activate the application of the thresholds everywhere.
With this PR we can activate the thresholds everywhere, by means of the boolean: "applySelectionsToAllCrystals"