Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if ZS of FR #22253

Closed
wants to merge 65 commits into from

Conversation

amassiro
Copy link
Contributor

Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if they have been read in Zero Suppression (ZS) of Full Readout (FR).

In the previous version we could activate these thresholds only in ZS regions, or de-activate the application of the thresholds everywhere.

With this PR we can activate the thresholds everywhere, by means of the boolean: "applySelectionsToAllCrystals"

kpedro88 and others added 30 commits January 25, 2018 13:50
…eInPath

Backport, Modify FileInPath to not lookup file in edmWriteConfigs
Restoring egamma DQM sequence for allForPrompt  (100X)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @amassiro (Andrea Massironi) for master.

It involves the following packages:

CalibTracker/SiStripESProducers
CondCore/Utilities
CondFormats/SiPixelObjects
Configuration/AlCa
Configuration/DataProcessing
Configuration/PyReleaseValidation
Configuration/StandardSequences
DQM/CSCMonitorModule
DQM/Integration
DQMOffline/Configuration
DQMOffline/Hcal
DataFormats/PatCandidates
DataFormats/SiPixelDigi
EventFilter/SiPixelRawToDigi
FWCore/ParameterSet
Geometry/CaloTopology
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo
HLTrigger/Configuration
Mixing/Base
PhysicsTools/NanoAOD
RecoEgamma/EgammaHLTProducers
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecProducers
RecoParticleFlow/PFClusterProducer
RecoVertex/BeamSpotProducer
SimCalorimetry/HcalTrigPrimAlgos
SimG4Core/Geometry
SimGeneral/MixingModule
Validation/CaloTowers
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits

@ghellwig, @ianna, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @thomreis, @vanbesien, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @kpedro88, @slava77, @ggovi, @fabiocos, @nsmith-, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @gouskos, @felicepantaleo, @jainshilpi, @Martin-Grunewald, @thomreis, @lgray, @threus, @mmusich, @seemasharmafnal, @mmarionncern, @battibass, @makortel, @geoff-smith, @jlagram, @HuguesBrun, @drkovalskyi, @ptcox, @rociovilar, @Sam-Harper, @barvic, @GiacomoSguazzoni, @tocheng, @VinInn, @rovere, @jalimena, @ebrondol, @dgulhan, @batinkov, @swertz, @varuns23, @gbenelli, @wddgit, @calderona, @dkotlins, @folguera, @cbernet, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

-1
wrong branch or needs rebase

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2018

-1

it looks like a wrong branch

@amassiro
Copy link
Contributor Author

Sorry, I confirm wrong branch!
Sorry for the noise.

@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@perrotta
Copy link
Contributor

-1
@amassiro please rebase, move it to the correct branch or whatever
As such the PR is unmergeable

@Martin-Grunewald
Copy link
Contributor

-1
please close this PR of fix it

@perrotta
Copy link
Contributor

@amassiro : you should probably close this one, now that you opened #22265 ...

@amassiro amassiro closed this Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment