HBHE: Local reco cpu

[mariadalfonso]

This PR save some CPU time here and there in the local RECO HBHE.
No changes expected in the offline reco.

1. Reference is plain 10_0_2:
   https://deguio.web.cern.ch/deguio/cgi-bin/igprof-navigator/MAHI/igreport_perf2017_CMSSW_10_0_2/15
2. Improvements at https://deguio.web.cern.ch/deguio/cgi-bin/igprof-navigator/MAHI/igreport_perf2017_CMSSW_10_0_X_2018-02-20-1100_profileTimeMahi+MRbranch+PS207+PR22206/15

@deguio

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22293/3495

[cmsbuild]

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

HLTrigger/Configuration
RecoLocalCalo/HcalRecAlgos

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith, @jalimena, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22293/3496

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26228/console Started: 2018/02/22 09:21

[cmsbuild]

+1
Tested at: f1ad65f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22293/26228/summary.html

[cmsbuild]

Comparison job queued.

[Martin-Grunewald]

Please update with the proper PR number.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22293/26228/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2498056
• DQMHistoTests: Total failures: 49
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497831
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.09000000005 KiB( 23 files compared)
• Checked 115 log files, 9 edm output root files, 28 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22293/3666

[mariadalfonso]

@abdoulline thanks for confirming, remove also this obsolete function
@slava77 @perrotta comments addressed

[cmsbuild]

Pull request #22293 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26434/console Started: 2018/03/02 12:09

[cmsbuild]

+1
Tested at: c857b1d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22293/26434/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22293/26434/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2479021
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2478844
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.980000000134 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #22293 c857b1d

• somewhat technical update to reduce unnecessary/repeated computations; also some cleanup of no longer used code.
  • timing profile of the offline reco shows about 5% reduction in CPU HBHE: Local reco cpu #22293 (comment)
• jenkins tests pass and comparisons with baseline show no differences.

@mariadalfonso
please check the PR descriptioin. It mentions

customizeHLTforCMSSW contains also the port

which is actually not a part of this PR and could be confusing

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1