Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

92X-tuned electron ID and removing upper bound for Zmass #22295

Merged
merged 1 commit into from Feb 27, 2018

Conversation

taroni
Copy link
Contributor

@taroni taroni commented Feb 22, 2018

92X tuned electron ID and no upper bound for Z Mass in the ZElectron skim used by ecal DPG
Presented at MoCa meeting on 21st February 2018. https://indico.cern.ch/event/699197/contributions/2900013/attachments/1604361/2544765/Zee.pdf
For CMSSW_10_1_X
@amassiro @crovelli @bmarzocc

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @taroni (Silvia Taroni) for master.

It involves the following packages:

DPGAnalysis/Skims

@cmsbuild, @GurpreetSinghChahal, @prebello, @fabozzi can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@taroni
Copy link
Contributor Author

taroni commented Feb 22, 2018

adding Nancy @nancymarinelli

@fabozzi
Copy link
Contributor

fabozzi commented Feb 23, 2018

please test workflow 136.781,136.829

@fabozzi
Copy link
Contributor

fabozzi commented Feb 23, 2018

@kfjack FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26255/console Started: 2018/02/23 10:23

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22295/26255/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2498056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497879
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.790000000183 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Feb 23, 2018

please test workflow 136.781

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26275/console Started: 2018/02/23 18:50

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22295/26275/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2498056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497879
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.670000000107 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Feb 24, 2018

@taroni
Can you check the ZElectron skim output from this test (workflow 136.781) to verify it is along your expectation before we sign off this PR?
Thank you!

@taroni
Copy link
Contributor Author

taroni commented Feb 26, 2018

The output is ok. Thanks

@fabozzi
Copy link
Contributor

fabozzi commented Feb 26, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b1c2f72 into cms-sw:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants