Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] HGCAL trigger updates #22296

Merged
merged 67 commits into from Mar 1, 2018
Merged

[Backport] HGCAL trigger updates #22296

merged 67 commits into from Mar 1, 2018

Conversation

jbsauvan
Copy link
Contributor

This is the backport in 93X of #21728

jbsauvan and others added 30 commits February 22, 2018 10:06
@jbsauvan
Increase TC nbits to 20
6658582
@jbsauvan
Update relval test file for 930pre4
9cbb014
@jbsauvan
first try
83ca58f
@jbsauvan
simplify and clean HGCalShowerShape
7fc49a7
@jbsauvan
First working version for Electron ID
837e2ba
@jbsauvan
dont use 2D shower shape for the moment
cd93bd5
@jbsauvan
new structure for HGCalShowerShape
f6327a8
@jbsauvan
clean version
a19d92f
@jbsauvan
Adress PR comments
85216c3
@jbsauvan
Adress PR comments Part II
38950b7
@jbsauvan
Adress PR comments Part III
d224c72
@jbsauvan
Address PR comments Part IV
88c5657
@jbsauvan
Remove useless comments
56d3195
@jbsauvan
Revert empty changes
e6a5ba6
@osahin @jbsauvan
The DBSCAN algorithm is implemented for the 3D clusters
1f02757
@osahin @jbsauvan
fixing minor bugs and correcting the parameters
299f148
@osahin @jbsauvan
Minor fixes (see comments to the PR)
ed31b3a
@osahin @jbsauvan
Minor fixes (see comments to the PR)
8fdf574
@osahin @jbsauvan
tabs are replaced with spaces
bfc16b6
@osahin @jbsauvan
tabs are replaced with spaces
3ff9fab
@osahin @jbsauvan
tabs are replaced with spaces
871040e
@osahin @jbsauvan
DBSCAN with 1D sorting is implemented. The sorted-DBSCAN performs up …
f061566 
…to 20 times faster than the unsorted version
@osahin @jbsauvan
OutOfBound excaption for the clustersPtrs is included
eb454e8
@osahin @jbsauvan
exceptions for the clusterPtrs' range are included in the findNeighbo…
6197708 
…r method
@osahin @jbsauvan
indexes are changed to unsinged
c5f72b4
@tstreble @jbsauvan
Optimized + extended HGC shower shape variables
f7d8e78
@tstreble @jbsauvan
Adressed style comments + fixed eMax computation
2202536
@tstreble @jbsauvan
Adressed style comments
c0ffc79
@tstreble @jbsauvan
Modified See, Spp and Szz computations
a33865b
@tstreble @jbsauvan
Typo fix
d05d286
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2018 •
edited

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for CMSSW_9_3_X.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal

@nsmith-, @cmsbuild, @kpedro88, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @kreczko, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test
@jbsauvan @rekovic this is for the L1T studies?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26236/console Started: 2018/02/22 17:47

@kpedro88
Copy link
Contributor

backport of #21728

@jbsauvan
Copy link
Contributor Author

Hi @kpedro88 , yes this is for the L1T production and studies.

@cmsbuild
Copy link
Contributor

+1
Tested at: 056330a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22296/26236/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22296/26236/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 224
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624047
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Feb 23, 2018

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Feb 28, 2018

@fabiocos
Can we please merge this in 93x. Thx

@fabiocos
Copy link
Contributor

fabiocos commented Mar 1, 2018

+1

@cmsbuild cmsbuild merged commit 0bd9e37 into cms-sw:CMSSW_9_3_X Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available fully-signed l1-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jbsauvan @cmsbuild @kpedro88 @rekovic @fabiocos @osahin @tstreble @mastrolorenzo