New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-sim22 Make pure EM physics lists #22304
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22304/3503 |
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4Core/PhysicsLists @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 |
@bsunanda , there is already DummyPhysics, because it is not used anywhere it can be considered for such test. We do not need extra plugin. At the same time, DummyEMPhysics class should be modified in a way that it is compatible with GeantV physics. What you included as a variant of EM physics is not compatible with GeantV - it has much more physics. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@bsunanda , to be more clear: GeantV physics is limited to gamma, e+, e- and only for limited set of basic processes. There is no sense instantiating CMS EM physics alone - no sense making Physics List as you did, because if, for example, one want to check current EM physics for gamma, e-, e+ he/she should use FTFP_BERT_EMM directly - no difference with what you propose. If we need reduced Physics List fully equivalent to GeantV, then it can be created on base of DummyEMPhysics.cc. |
This is superseded by PR #22357 submitted by Vladimir. |
In view of tests with GeantV. One has to choose Physics.type = "SImG4Core/Physics/EMPhysics" and with Physics.EMPhysics set to true|false one chooses the EMStandard and EML lists