Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-sim22 Make pure EM physics lists #22304

Closed
wants to merge 2 commits into from

Conversation

bsunanda
Copy link
Contributor

In view of tests with GeantV. One has to choose Physics.type = "SImG4Core/Physics/EMPhysics" and with Physics.EMPhysics set to true|false one chooses the EMStandard and EML lists

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Feb 22, 2018

-1

@civanch
Copy link
Contributor

civanch commented Feb 22, 2018

@bsunanda , there is already DummyPhysics, because it is not used anywhere it can be considered for such test. We do not need extra plugin. At the same time, DummyEMPhysics class should be modified in a way that it is compatible with GeantV physics. What you included as a variant of EM physics is not compatible with GeantV - it has much more physics.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26241/console Started: 2018/02/22 18:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22304/26241/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2498056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497879
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.889999999948 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

@civanch
Copy link
Contributor

civanch commented Feb 23, 2018

@bsunanda , to be more clear: GeantV physics is limited to gamma, e+, e- and only for limited set of basic processes. There is no sense instantiating CMS EM physics alone - no sense making Physics List as you did, because if, for example, one want to check current EM physics for gamma, e-, e+ he/she should use FTFP_BERT_EMM directly - no difference with what you propose. If we need reduced Physics List fully equivalent to GeantV, then it can be created on base of DummyEMPhysics.cc.

@bsunanda
Copy link
Contributor Author

This is superseded by PR #22357 submitted by Vladimir.

@bsunanda bsunanda closed this Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants