Improve seed finding for L3 muon reconstruction at HLT #22321
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22321/3532 |
|
A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for master. It involves the following packages: RecoMuon/TrackerSeedGenerator @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
| findSeedsOnLayer(tTopo, **it, tsosAtMuonSystem, *(propagatorOpposite.get()), *(propagatorOpposite.get()), l2, | ||
| estimatorH, measurementTrackerH, numSeedsMade, numOfMaxSeeds, layerCount, analysedL2, out); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
the following should apparently replace L148 - L206 and get rid of triple copy-paste.
Capturing of individual variables was unavoidable instead of a simple [&]
//generic region lambda
auto loopOneRegion = [&layerCount,&tTopo,&l2,&estimatorH,&measurementTrackerH,&numSeedsMade,&numOfMaxSeeds,&analysedL2,&out,this]
(const auto& tsos, const auto& reg, const std::string& regS, const auto& propA, const auto& propB){
for (auto it=reg.rbegin(); it!=reg.rend(); ++it) {
LogTrace("TSGForOI") << "TSGForOI::produce: looping in "<<regS<<" layer " << layerCount << endl;
findSeedsOnLayer(tTopo, **it, tsos, *propA, *propB, l2,
estimatorH, measurementTrackerH, numSeedsMade, numOfMaxSeeds, layerCount, analysedL2, out);
}
};
auto doRegion = [&tsosAtIP,&tsosAtMuonSystem,&propagatorAlong,&propagatorOpposite,&layerCount,&numSeedsMade,&useBoth,&loopOneRegion]
(const auto& reg, const std::string& regS){
layerCount = 0;
loopOneRegion(tsosAtIP, reg, regS, propagatorAlong, propagatorOpposite);
if (useBoth){
numSeedsMade=0;
loopOneRegion(tsosAtMuonSystem, reg, regS, propagatorOpposite, propagatorOpposite);
}
};
// BARREL
if (std::abs(l2->eta()) < maxEtaForTOB_) doRegion(tob, "TOB");
//Reset Number of seeds if in overlap region:
if (std::abs(l2->eta())>minEtaForTEC_ && std::abs(l2->eta())<maxEtaForTOB_){
numSeedsMade=0;
}
// ENDCAP+
if (l2->eta() > minEtaForTEC_) doRegion(tecPositive, "TEC+");
// ENDCAP-
if (l2->eta() < -minEtaForTEC_) doRegion(tecNegative, "TEC-");feel free to consider this for refactoring. It compiles, but I didn't cross check for identity.
cmsbuild
added
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
assign hlt @silviodonato @Martin-Grunewald |
|
New categories assigned: hlt @Martin-Grunewald,@silviodonato,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
@slava77 |
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR improves the seed finding for the outside-in muon reconstruction in the HLT.
it involves:
The efficiency gain for the OI L3 reconstructions is documented in these slides https://cernbox.cern.ch/index.php/s/chcY6XHGUGDV9Xk, which include links to the discussion on this topic in the Muon HLT Task Force.