Updating MET Significance Parameters with 80X Run2016 tune

[danbarto]

Updating the parameters for MET Significance with the latest tune (as used in JME-17-001).

[cmsbuild]

A new Pull Request was created by @danbarto (Daniel) for CMSSW_9_4_MAOD_X.

It involves the following packages:

RecoMET/METProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Updating MET Significance Parameters with 80X Run2016 tune #22315

[perrotta]

backport of #22315

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26438/console Started: 2018/03/02 14:40

[cmsbuild]

-1

Tested at: 6827a83

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22347/26438/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

[cmsbuild]

Comparison job queued.

[perrotta]

please test
(the usual glitch with no indication about which AddOn test failed?)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26463/console Started: 2018/03/02 20:29

[cmsbuild]

+1
Tested at: 6827a83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22347/26463/summary.html

[cmsbuild]

Comparison job queued.

[perrotta]

With a grep in the release I can find a possible example in RecoEgamma/EgammaPhotonProducers/python/reducedEgamma_cfi.py

In your case, you can restore the previous values of the parameters, and then replace the new ones as, e.g.:

from Configuration.Eras.Modifier_run2_miniAOD_80XLegacy_cff import run2_miniAOD_80XLegacy
#Run II MC, based on 80X
run2_miniAOD_80XLegacy.toModify(METSignificanceParams,
   jpar = cms.vdouble(1.39,1.26,1.21,1.23,1.28),
   pjpar = cms.vdouble(-0.2586,0.6173)
)
#Run II data, based on 80X
run2_miniAOD_80XLegacy.toModify(METSignificanceParams_Data,
   jpar = cms.vdouble(1.38,1.28,1.22,1.16,1.10),
   pjpar = cms.vdouble(0.0033,0.5802)
)
from Configuration.Eras.Modifier_run2_miniAOD_94XFall17_cff import run2_miniAOD_94XFall17
#Run II MC, based on 80X
run2_miniAOD_94XFall17.toModify(METSignificanceParams,
   jpar = cms.vdouble(1.39,1.26,1.21,1.23,1.28),
   pjpar = cms.vdouble(-0.2586,0.6173)
)
#Run II data, based on 80X
run2_miniAOD_94XFall17.toModify(METSignificanceParams_Data,
   jpar = cms.vdouble(1.38,1.28,1.22,1.16,1.10),
   pjpar = cms.vdouble(0.0033,0.5802)
)

[slava77]

the following will be more compact and will avoid unnecessary copy-paste

from Configuration.Eras.Modifier_run2_miniAOD_80XLegacy_cff import run2_miniAOD_80XLegacy
from Configuration.Eras.Modifier_run2_miniAOD_94XFall17_cff import run2_miniAOD_94XFall17

for mod in [ run2_miniAOD_80XLegacy, run2_miniAOD_94XFall17]:
    mod.toModify(METSignificanceParams, 
                             jpar = [1.39,1.26,1.21,1.23,1.28],
                             pjpar = [-0.2586,0.6173])

[cmsbuild]

Pull request #22347 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26735/console Started: 2018/03/09 18:03

[cmsbuild]

+1
Tested at: 8906a8d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22347/26735/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22347/26735/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 104
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721227
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 110 log files, 9 edm output root files, 27 DQM output files

[perrotta]

+1

• MET significance parameters updated in miniAOD following the latest prescriptions of the MET group
• The difference wrt the same PR now merged in the master is that in this 94X backport the updates are only allowed in the run2_miniAOD_80XLegacy and run2_miniAOD_94XFall17
• The jenkns tests cerify that the modifications only appears in those eras

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1