Pr101x L1T integration development and fixes upto v97.16

[rekovic]

PR 10_1_X L1T integration development and fixes upto v97.16.

Content:

• This PR mostly contains configuration files (29) used for expert offline studies. The only configuration files of this PR used in any central workflows are

   Configuration/StandardSequences/python/SimL1EmulatorRepack_Full_cff.py`
   L1Trigger/L1TCalorimeter/python/hackConditions_cff.py`
   L1Trigger/L1TMuon/python/simGmtStage2Digis_cfi.py
   L1Trigger/L1TMuonBarrel/python/simBmtfDigis_cfi.py

Features and fixes:

• BMTF: sim Digis set default input to TwinMux (previously simDT TP Digis)
• uGMT
  • emulator: functionality for EMTF track-based cancel out. Default still coordinate-based.
  • packer: activate packing of inputs and upgrade it not to pack empty links and fix segfaulting when BX range is even
• L1REPACK:
  • L1REPACK:Fullfix - use unpacked OMTF as inputs
  • L1REPACK:CalouGT - new workflow to only re-emulate Calo and uGT and to use unpacked uGT muons
• Calo
  • Fix Tau emulator discrepancy emul/firmware affecting position of L1Tau candidates if merged
  • Fix EG/Tau emulator: (a) sorting in case 2 cands with same E found at same eta position. (b) fix for iso sums affecting size of the isolation window when extending in HF (TT26 and beyond)
• Calo configurations for purely offline studies:
• Fixes in L1TNtuples
  • Fix memory leak in L1JetRecoTreeProducer
  • Add caloJets to L1Ntuples, calo jet corrections & caloHT and update met filters, jet id req, new met v7
  • Remove precaled muon triggers from matching for RecoMuonTree

[cmsbuild]

The code-checks are being triggered in jenkins.

[rekovic]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22368/3580

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26336/console Started: 2018/02/27 09:54

[cmsbuild]

A new Pull Request was created by @rekovic for master.

It involves the following packages:

Configuration/Applications
Configuration/StandardSequences
DataFormats/L1TMuon
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
EventFilter/L1TXRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCalorimeter
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TNtuples

@cmsbuild, @nsmith-, @rekovic, @franzoni, @thomreis, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @thomreis, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c861085
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22368/26336/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22368/26336/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22368/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2500248
• DQMHistoTests: Total failures: 2740
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497332
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.920000000115 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[rekovic]

+1

[fabiocos]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.