speeding up L1TGlobalProducer

[Sam-Harper]

Inside the L1TGlobalProducer objects were accidentally being returned by value not reference, leading to an unnecessary ~1.4% in HLT timing which I feel would be much better spent on other things, such as, for example, E/gamma track isolation :)

This simple patch fixes it. As the only change is now objects which were copies are now constant references, zero output changes are expected.

pre fix igprof:
sharper.web.cern.ch/sharper/cgi-bin/igprof-navigator/1001HLTTiming/igreport_HLT10XWithTrkIso

post fix igprof
http://sharper.web.cern.ch/sharper/cgi-bin/igprof-navigator/1001HLTTiming/igreport_HLT10XWithTrkIsoL1Fix

From timeDiffFromReport.sh
-0.918408 -1.40% 5.55 ms/ev -> 2.06 ms/ev hltGtStage2ObjectMap

FYI: @Martin-Grunewald

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22390/3613

[cmsbuild]

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

L1Trigger/L1TGlobal

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[Martin-Grunewald]

This is great @Sam-Harper

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26380/console Started: 2018/02/28 17:47

[cmsbuild]

-1

Tested at: d44214c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22390/26380/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

1001.0 step1

DAS Error

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26432/console Started: 2018/03/02 11:04

[cmsbuild]

+1
Tested at: d44214c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22390/26432/summary.html

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[rekovic]

Thx @Sam-Harper !

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22390/26432/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2479021
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2478844
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.26999999999 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1