Scouting - add track collection #22401
Conversation
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_10_0_X. It involves the following packages: DataFormats/Scouting @smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
| @@ -24,18 +24,23 @@ | |||
| <class name="ScoutingPhoton" ClassVersion="2"> | |||
| <version ClassVersion="2" checksum="2797410539"/> | |||
| </class> | |||
| <class name="ScoutingTrack" ClassVersion="-1"> | |||
There was a problem hiding this comment.
The version number should be 2
|
|
||
| public: | ||
| explicit HLTScoutingTrackProducer(const edm::ParameterSet&); | ||
| ~HLTScoutingTrackProducer() override; |
There was a problem hiding this comment.
There is no need to declare the destructor
| void produce(edm::StreamID sid, edm::Event & iEvent, edm::EventSetup const & setup) | ||
| const final; | ||
|
|
||
| const edm::EDGetTokenT<reco::TrackCollection> OtherTrackCollection_; |
There was a problem hiding this comment.
CMS coding convention is to start member variables with a lower case letter
|
|
||
| #include "HLTScoutingTrackProducer.h" | ||
| #include "DataFormats/Math/interface/deltaR.h" | ||
| #include "TMath.h" |
There was a problem hiding this comment.
Are the last two includes needed?
| @@ -0,0 +1,62 @@ | |||
| #ifndef HLTScoutingTrackProducer_h | |||
| #define HLTScoutingTrackProducer_h | |||
|
|
|||
There was a problem hiding this comment.
It is best to remove this file and put its content directly in the corresponding .cc file.
|
Pull request #22401 was updated. @smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
We need a 10_1 PR first! |
|
+1 |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
backport of #22418 |
|
+1 |
These changes are meant for scouting event content only. The dimuon calo scouting HLT paths produce a track collection in order to compute track-isolation of muons, that track collection can be saved in event content, and can be used in analyses. Using edmEventSize, I obtained the size of the collection.
Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event)
ScoutingTracks_hltScoutingTrackPacker__MYHLT. | 1103.12 | 876.943