CalibTracker: cleanup clang warnings #22407
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22407/3647 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22407/3647/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22407/3648 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: CalibTracker/SiPixelTools @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| void bookHistograms(DQMStore::IBooker &, edm::Run const &, edm::EventSetup const &) override; | ||
| void dqmBeginRun(edm::Run const&, edm::EventSetup const&) override; | ||
| void analyze(const edm::Event&, const edm::EventSetup&) override; | ||
| virtual void endJob() ; | ||
| virtual void endJob() override; |
There was a problem hiding this comment.
virtual can be removed from this line.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22407/3682 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Cleanup these clang warnings in CalibTracker packages:
CalibTracker/SiPixelTools/plugins/SiPixelFedFillerWordEventNumber.cc:63:16: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
CalibTracker/SiPixelTools/plugins/SiPixelErrorsDigisToCalibDigis.cc:149:13: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
CalibTracker/SiStripChannelGain/interface/SiStripGainsPCLWorker.h:81:18: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEffFromCalibTree.cc:98:18: warning: 'SiStripHitEffFromCalibTree::algoBeginJob' hides overloaded virtual function [-Woverloaded-virtual]