Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleMuon and Charmonium skim for MUO POG #22421

Merged
merged 9 commits into from Mar 12, 2018
Merged

Conversation

sscruz
Copy link
Contributor

@sscruz sscruz commented Mar 2, 2018

Configuration for skims of SingleMuon and Charmonium datasets for MUO
@kfjack wants to follow this

@cmsbuild cmsbuild changed the base branch from CMSSW_10_1_X to master March 2, 2018 14:55
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

@sscruz, CMSSW_10_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

A new Pull Request was created by @sscruz for master.

It involves the following packages:

CommonTools/RecoAlgos
Configuration/Skimming

@perrotta, @prebello, @fabozzi, @cmsbuild, @slava77, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @Martin-Grunewald, @ahinzmann, @gkasieczka this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

The code-checks are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 2, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26451/console Started: 2018/03/02 17:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Pull request #22421 was updated. @perrotta, @prebello, @fabozzi, @cmsbuild, @slava77, @GurpreetSinghChahal can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Pull request #22421 was updated. @perrotta, @prebello, @fabozzi, @cmsbuild, @gpetruc, @slava77, @GurpreetSinghChahal, @monttj, @arizzi can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26707/console Started: 2018/03/08 21:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22421/26707/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2484711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2484534
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.749999999818 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 9, 2018

+1

for #22421 2161faa

  • relatively simple changes in what regards reco signature: IsoTrackSelector and MuonRefPatCount selectors/filters are added for pat objects in PhysicsTools/PatAlgos/plugins/PATObjectSelector
  • jenkins tests pass

@fabozzi
Copy link
Contributor

fabozzi commented Mar 10, 2018

@kfjack These skims should be integrated in data relvals for regular testing (this can be done in a separate PR, after this is merged)

@fabozzi
Copy link
Contributor

fabozzi commented Mar 10, 2018

+1

@kfjack
Copy link
Contributor

kfjack commented Mar 11, 2018

@fabozzi OK will take care of the relval afterwards!

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 79b4ac4 into cms-sw:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants