adding Egamma 2016/2017 IDs to MiniAOD and removing old ones #22428

Sam-Harper · 2018-03-02T16:47:38Z

Dear All,

This is the ID part of #22308

It adds the 2016/2017 VID IDs to the pat::Electrons/Photons and removes all other IDs for the 2017 re-MiniAOD.

The userData and IDs in the electrons/photons are

egammaDebug: pho event 303948 1007381646 2481  E/pt/eta/phi 157.283 16.9529 -2.91784 1.06988 
   userFloats: 
          PhotonMVAEstimatorRun2Spring16NonTrigV1Values 0.989729
          PhotonMVAEstimatorRunIIFall17v1Values 0.989083
          PhotonMVAEstimatorRunIIFall17v1p1Values 0.988155
          phoChargedIsolation 0
          phoNeutralHadronIsolation 3.47616
          phoPhotonIsolation 0
          phoWorstChargedIsolation 1.85928
   userInts: 
          PhotonMVAEstimatorRun2Spring16NonTrigV1Categories 1
          PhotonMVAEstimatorRunIIFall17v1Categories 1
          PhotonMVAEstimatorRunIIFall17v1p1Categories 1
          cutBasedPhotonID-Fall17-94X-V1-loose 125
          cutBasedPhotonID-Fall17-94X-V1-medium 125
          cutBasedPhotonID-Fall17-94X-V1-tight 125
          cutBasedPhotonID-Spring16-V2p2-loose 125
          cutBasedPhotonID-Spring16-V2p2-medium 93
          cutBasedPhotonID-Spring16-V2p2-tight 93
   photonIDs: 
          cutBasedPhotonID-Fall17-94X-V1-loose 0
          cutBasedPhotonID-Fall17-94X-V1-medium 0
          cutBasedPhotonID-Fall17-94X-V1-tight 0
          cutBasedPhotonID-Spring16-V2p2-loose 0
          cutBasedPhotonID-Spring16-V2p2-medium 0
          cutBasedPhotonID-Spring16-V2p2-tight 0
          mvaPhoID-RunIIFall17-v1-wp80 1
          mvaPhoID-RunIIFall17-v1-wp90 1
          mvaPhoID-RunIIFall17-v1p1-wp80 1
          mvaPhoID-RunIIFall17-v1p1-wp90 1
          mvaPhoID-Spring16-nonTrig-V1-wp80 1
          mvaPhoID-Spring16-nonTrig-V1-wp90 1

egammaDebug: ele event 303948 1007381646 2481  E/pt/eta/phi 394.544 74.091 2.35665 0.537025 ecal 3.47476 hcal 8.89551
   userFloats: 
          ElectronMVAEstimatorRun2Fall17IsoV1Values -0.982789
          ElectronMVAEstimatorRun2Fall17NoIsoV1Values -0.948833
          ElectronMVAEstimatorRun2Spring16GeneralPurposeV1Values -0.992946
          ElectronMVAEstimatorRun2Spring16HZZV1Values -0.982216
          heepV70TrkPtIso 5.60547
   userInts: 
          ElectronMVAEstimatorRun2Fall17IsoV1Categories 5
          ElectronMVAEstimatorRun2Fall17NoIsoV1Categories 5
          ElectronMVAEstimatorRun2Spring16GeneralPurposeV1Categories 2
          ElectronMVAEstimatorRun2Spring16HZZV1Categories 5
          cutBasedElectronID-Fall17-94X-V1-loose 987
          cutBasedElectronID-Fall17-94X-V1-medium 923
          cutBasedElectronID-Fall17-94X-V1-tight 787
          cutBasedElectronID-Fall17-94X-V1-veto 987
          cutBasedElectronID-Summer16-80X-V1-loose 1019
          cutBasedElectronID-Summer16-80X-V1-medium 891
          cutBasedElectronID-Summer16-80X-V1-tight 795
          cutBasedElectronID-Summer16-80X-V1-veto 1019
          heepElectronID-HEEPV70 1851
   electronIDs: 
          cutBasedElectronID-Fall17-94X-V1-loose 0
          cutBasedElectronID-Fall17-94X-V1-medium 0
          cutBasedElectronID-Fall17-94X-V1-tight 0
          cutBasedElectronID-Fall17-94X-V1-veto 0
          cutBasedElectronID-Summer16-80X-V1-loose 0
          cutBasedElectronID-Summer16-80X-V1-medium 0
          cutBasedElectronID-Summer16-80X-V1-tight 0
          cutBasedElectronID-Summer16-80X-V1-veto 0
          heepElectronID-HEEPV70 0
          mvaEleID-Fall17-iso-V1-wp80 0
          mvaEleID-Fall17-iso-V1-wp90 0
          mvaEleID-Fall17-iso-V1-wpLoose 0
          mvaEleID-Fall17-noIso-V1-wp80 0
          mvaEleID-Fall17-noIso-V1-wp90 0
          mvaEleID-Fall17-noIso-V1-wpLoose 0
          mvaEleID-Spring16-GeneralPurpose-V1-wp80 0
          mvaEleID-Spring16-GeneralPurpose-V1-wp90 0
          mvaEleID-Spring16-HZZ-V1-wpLoose 0

cmsbuild · 2018-03-02T16:47:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-02T16:51:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22428/3686

cmsbuild · 2018-03-02T16:51:53Z

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @jainshilpi, @rappoccio, @varuns23, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @acaudron, @lgray, @jdolen, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-03-02T17:25:46Z

@cmsbuild please test

cmsbuild · 2018-03-02T17:26:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26458/console Started: 2018/03/02 18:48

cmsbuild · 2018-03-02T19:52:23Z

-1

Tested at: 7445d79

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22428/26458/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoEgammaPhotonIdentification had ERRORS

cmsbuild · 2018-03-02T19:52:25Z

Comparison job queued.

cmsbuild · 2018-03-02T20:34:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22428/26458/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1071 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2479021
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2478844
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.00000000007 KiB( 21 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

cmsbuild · 2018-03-07T20:56:17Z

The code-checks are being triggered in jenkins.

slava77 · 2018-03-07T20:58:09Z

@cmsbuild please test

@Sam-Harper
thank you for the updates.
It looks like we are almost done with this.

cmsbuild · 2018-03-07T20:58:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22428/3822

cmsbuild · 2018-03-07T20:58:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26674/console Started: 2018/03/07 21:59

cmsbuild · 2018-03-07T20:58:32Z

Pull request #22428 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

cmsbuild · 2018-03-07T22:41:55Z

+1
Tested at: 0cef6b6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22428/26674/summary.html

cmsbuild · 2018-03-07T22:41:58Z

Comparison job queued.

cmsbuild · 2018-03-08T00:07:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22428/26674/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1076 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2480211
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2480034
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.10000000009 KiB( 22 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

slava77 · 2018-03-08T03:35:21Z

+1

for #22428 0cef6b6

code changes are in line with the PR description (modulo the last change in heepV70TrkPtIso -> heepTrkPtIso); essentially all changes are in the configuration for the code that was signed off previously
jenkins tests pass and comparisons with the baseline show differences only in the following pattern "slimmedPhotons[^$]*photonIDs|slimmedPhotons[^$]*userFloats|slimmedPhotons[^$]*userInts|slimmedElectrons[^$]*electronIDs|slimmedElectrons[^$]*userInts|slimmedElectrons[^$]*userFloats" as expected
- there are no changes in the standard DQM plots, which is a reflection of lack of monitoring of the egamma IDs
local tests checking time, memory, and size at run time show expected and acceptable changes:
- memory use has decreased by about 8MB in a combination of MVAValueMapProducers for electrons and photons
- CPU time changes are rather negligible, for a total of maybe 1 ms/ev decrease (0.05% effect, in the noise)
- the combined change in saved variables in slimmedPhoton and slimmedElectrons increases the event size by about 14 bytes each compressed (+28 bytes total), and by about 95 bytes uncompressed. This is based on 1K events and the compressed size increase is likely smaller on more events.

slava77 · 2018-03-10T14:38:06Z

@fabiocos
this PR somewhat stands in the way of integrating the latest egamma PR on scale&smearing #22531
Please check and integrate at your earliest if there are no issues.

fabiocos · 2018-03-10T16:37:21Z

+1

fabiocos · 2018-03-10T16:37:26Z

merge

cmsbuild added this to the CMSSW_10_1_X milestone Mar 2, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 2, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 2, 2018

cmsbuild added tests-rejected and removed tests-started labels Mar 2, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 2, 2018

adding 2016/2017 IDs to MiniAOD and removing old ones

67fd2ab

Sam-Harper force-pushed the EGMIDsForReMiniAOD_101X branch from 7445d79 to 67fd2ab Compare March 2, 2018 20:48

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-rejected labels Mar 2, 2018

cmsbuild added code-checks-pending tests-pending and removed tests-approved labels Mar 7, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 7, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 7, 2018

cmsbuild added tests-approved and removed tests-started labels Mar 7, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 8, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 8, 2018

slava77 mentioned this pull request Mar 9, 2018

features needed for 94X re-miniAOD #21864

Closed

15 tasks

Sam-Harper mentioned this pull request Mar 9, 2018

adding Egamma 2016/2017 IDs to MiniAOD : 94X MiniAOD #22550

Merged

cmsbuild added orp-approved and removed orp-pending labels Mar 10, 2018

cmsbuild merged commit db207e1 into cms-sw:master Mar 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding Egamma 2016/2017 IDs to MiniAOD and removing old ones #22428

adding Egamma 2016/2017 IDs to MiniAOD and removing old ones #22428

Sam-Harper commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

slava77 commented Mar 2, 2018

cmsbuild commented Mar 2, 2018 •

edited

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 7, 2018

slava77 commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018 •

edited

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 8, 2018

slava77 commented Mar 8, 2018

slava77 commented Mar 10, 2018

fabiocos commented Mar 10, 2018

fabiocos commented Mar 10, 2018

adding Egamma 2016/2017 IDs to MiniAOD and removing old ones #22428

adding Egamma 2016/2017 IDs to MiniAOD and removing old ones #22428

Conversation

Sam-Harper commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

slava77 commented Mar 2, 2018

cmsbuild commented Mar 2, 2018 • edited

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 7, 2018

slava77 commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018 • edited

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 8, 2018

slava77 commented Mar 8, 2018

slava77 commented Mar 10, 2018

fabiocos commented Mar 10, 2018

fabiocos commented Mar 10, 2018

cmsbuild commented Mar 2, 2018 •

edited

cmsbuild commented Mar 7, 2018 •

edited