GenParticles2HepMCConverter null pointer protection 10X

[jhgoh]

10X version of PR #22440

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22441/3703

[cmsbuild]

A new Pull Request was created by @jhgoh (Junghwan John Goh) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26479/console Started: 2018/03/03 09:58

[cmsbuild]

+1
Tested at: ea450e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22441/26479/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22441/26479/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2479021
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2478844
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.07000000007 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@perrozzi I understand that this PR is changing the event history for particle guns, are we sure that there is nothing assuming the absence of input particle on that? I would say so, no effect is seen in the output of the test...

[fabiocos]

+1

affecting only generator history for particle guns (technical fix to circumvent problems in NanoAOD creation)