Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two version of the Phase2 Tracker and corresponding workflows for testing and relvals purpose #22463

Merged
merged 7 commits into from Mar 14, 2018

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 5, 2018

Greetings
This PR aims to add two new version of the tracker for testing purpose.

The main feature of the Tracker (T7 and T8 ) are :

  1. T7: Phase2 tilted tracker (v6.1.3) w/ phase 2 pixel (v4.2.0)
    --> same as T6 but 25x100 in 1x2 modules, 50x200 in 2x2 modules
  2. T8: Phase2 tilted tracker (v6.1.3) w/ phase 2 pixel (v4.2.1)
    --> same as T6 but 25x100 in 1x2 modules, 100x100 in 2x2 modules

Those Tracker would benefit to get relvals for physics performance in order to guide R&Ds choice

The corresponding Workflows for T7 and T8 are D22 (216xx) and D23 (220xx) -

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData

@prebello, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @civanch, @GurpreetSinghChahal, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @ghugo83, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 5, 2018

@boudoul do we need to update CPE errors for these new trackers?

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The tests are being triggered in jenkins.

@boudoul
Copy link
Contributor Author

boudoul commented Mar 5, 2018

@emiglior FYI

@boudoul
Copy link
Contributor Author

boudoul commented Mar 5, 2018

hello @kpedro88 , we will need eventually but we first need WFs to generate the events needed to derive them .

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 5, 2018

I see, I'll await the subsequent PR then

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 6, 2018

@boudoul do you want to add some of the WFs to relval_2023.py so they can be tested in the regular matrix?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22463/26711/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22463/21634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D22_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D22+RecoFullGlobal_2023D22+HARVESTFullGlobal_2023D22
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22463/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D23_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D23+RecoFullGlobal_2023D23+HARVESTFullGlobal_2023D23

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2484711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2484534
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.989999999962 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 9, 2018

+1

@ianna
Copy link
Contributor

ianna commented Mar 10, 2018

+1

@boudoul
Copy link
Contributor Author

boudoul commented Mar 12, 2018

Hello @prebello, @fabozzi, @GurpreetSinghChahal, could you please take a look and sign this PR ? Thank you .

@prebello
Copy link
Contributor

+1

@boudoul
Copy link
Contributor Author

boudoul commented Mar 13, 2018

dear @franzoni @davidlange6 @fabiocos , could you please sign for operation ? thank you.

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 80471c6 into cms-sw:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants