Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New psets for Phase2PixelNtuple #22464

Merged
merged 4 commits into from Mar 15, 2018

Conversation

emiglior
Copy link
Contributor

@emiglior emiglior commented Mar 5, 2018

This is an update of PR #22204. Two psets are provided:
1/ phase2_reco_pixelntuple_cfg.py: ntuples from DIGI to perform RECO level studies, e.g. CPE errors calibration)
2/ phase2_digi_reco_pixelntuple_cfg.py ntuples from SIM to produce "stimuli" for RD53 studies (InnerTracker PROC deisgn)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

A new Pull Request was created by @emiglior (Ernesto Migliore) for master.

It involves the following packages:

SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@@ -0,0 +1,66 @@
This is a short description of the content of the ntuple produced by Phase2PixelNtuple.cc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please actually use markdown in this file so it is readable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @emiglior , I guess this comment should be adressed , thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpedro88 sorry for the slow reaction... any suggestion, reference, cmssw example for md style is welcome

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26523/console Started: 2018/03/05 19:15

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22464/26523/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.19000000002 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@ianna
Copy link
Contributor

ianna commented Mar 6, 2018

+1

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #22464 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26814/console Started: 2018/03/13 14:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented Mar 13, 2018

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22464/26814/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2477528
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2477351
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.22000000012 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4b1947 into cms-sw:master Mar 15, 2018
@emiglior emiglior deleted the phase2pixelntuple_new_psets branch October 9, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants