Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lorentz angle by module #2247

Merged

Conversation

hidaspal
Copy link
Contributor

Creates Lorentz angle payload with LA values per module, instead of per BPIX/FPIX only. Code already tested and used last year from private area.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hidaspal for CMSSW_7_1_X.

Lorentz angle by module

It involves the following packages:

CalibTracker/SiPixelLorentzAngle
CondTools/SiPixel

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@apfeiffer1
Copy link
Contributor

+1

@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 10, 2014
…_pre1

CalibTracker -- Lorentz angle by module
@nclopezo nclopezo merged commit 031ab77 into cms-sw:CMSSW_7_1_X Feb 10, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@diguida diguida mentioned this pull request Feb 28, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants