PR for HLT matching PFtau to L1T jets #22488
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22488/3774 |
|
A new Pull Request was created by @albertdow for master. It involves the following packages: RecoTauTag/HLTProducers @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Given the resolution of L1T objects, using only the leading L1T is not robust! |
|
|
||
| for(unsigned int iTau = 0; iTau < taus->size(); iTau++){ | ||
| if ((*taus)[iTau].pt() > minTauPt_){ | ||
| if(reco::deltaR2((*taus)[iTau].p4(), jetCandRefVec[0]->p4()) < matchingR2_) |
There was a problem hiding this comment.
jetCandRefVec might be size 0 so that element [0] does not exist.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22488/3805 |
|
Pull request #22488 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
albertdow
changed the title
| } | ||
| } | ||
| } | ||
| if(isMatched == true) L1TmatchedPFTau->push_back((*taus)[iTau]); |
There was a problem hiding this comment.
if (isMatched) L1T...
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22488/3834 |
|
Pull request #22488 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR concerns
RecoTauTag/HLTProducersand is required for a special case of the VBF + Taus HLT trigger:HLT_(VBF_DoubleJet40)_DiTau_115_20,triggered by the VBF L1 seeds (eg.
L1_DoubleJet_115_40_DoubleJet40_Mass_Min620)The idea is that the PFTau 115 is matched to the (leading) L1T jet.
This trigger comes with two other triggers:
HLT_(VBF_DoubleJet115_40)_DiTau_20HLT_(VBF_DoubleJet40)_SingleJet115_DiTau_20.The PR is required asap to finalise the HLT config.