SimG4Core packages: clean up clang warnings:

[gartung]

SimG4Core/HelpfulWatchers/src/SimTracer.h:67:1: warning: 'update' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
UPDATE(DDDWorld)
^
SimG4Core/HelpfulWatchers/src/SimTracer.h:43:27: note: expanded from macro 'UPDATE'
^

SimG4Core/HelpfulWatchers/src/G4StepStatistics.h:156:1: warning: 'update' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
UPDATE(DDDWorld)
^

SimG4Core/HelpfulWatchers/src/G4StepStatistics.h:129:27: note: expanded from macro 'UPDATE'
^

SimG4Core/PhysicsLists/interface/CMSFTFPNeutronBuilder.hh:33:10: warning: 'SetMinEnergy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetMinEnergy(G4double aM) {theMin = aM;}
^

SimG4Core/PhysicsLists/interface/CMSFTFPNeutronBuilder.hh:34:10: warning: 'SetMaxEnergy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetMaxEnergy(G4double aM) {theMax = aM;}
^

SimG4Core/PhysicsLists/interface/CMSFTFPPiKBuilder.hh:38:10: warning: 'SetMinEnergy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetMinEnergy(G4double aM) {theMin = aM;}
^

SimG4Core/PhysicsLists/interface/CMSFTFPPiKBuilder.hh:39:10: warning: 'SetMaxEnergy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetMaxEnergy(G4double aM) {theMax = aM;}
^

SimG4Core/PhysicsLists/interface/CMSFTFPProtonBuilder.hh:31:10: warning: 'SetMinEnergy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetMinEnergy(G4double aM) {theMin = aM;}
^

SimG4Core/PhysicsLists/interface/CMSFTFPProtonBuilder.hh:32:10: warning: 'SetMaxEnergy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetMaxEnergy(G4double aM) {theMax = aM;}
^

[gartung]

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22496/3783

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

SimG4Core/HelpfulWatchers
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26612/console Started: 2018/03/06 22:23

[cmsbuild]

+1
Tested at: 1ecfb62
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22496/26612/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a6f7e8e
cac3d87
226b882
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22496/26612/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22496/26612/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22496/26612/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2479021
• DQMHistoTests: Total failures: 1032
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477813
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1558.86 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

The differences are concentrated in a FastSim workflow, and looks unrelated to this PR, most likely due to the fastsim muon fix included in the merge

[fabiocos]

+1