Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTriggerOffline packages: clean up clang warnings: #22501

Merged
merged 2 commits into from Mar 8, 2018
Merged

HLTriggerOffline packages: clean up clang warnings: #22501

merged 2 commits into from Mar 8, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Mar 6, 2018

HLTriggerOffline/Egamma/interface/EmDQM.h:79:8: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void beginJob();
^

HLTriggerOffline/Egamma/interface/EmDQM.h:80:8: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void endJob();
^

HLTriggerOffline/Exotica/interface/HLTExoticaValidator.h:49:18: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void beginJob();
^

HLTriggerOffline/Exotica/interface/HLTExoticaValidator.h:55:18: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void endJob();
^

HLTriggerOffline/Muon/src/HLTMuonValidator.cc:51:16: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void beginJob();
^

HLTriggerOffline/Muon/src/HLTMuonValidator.cc:56:16: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void endJob();
^

HLTriggerOffline/Egamma/interface/EmDQM.h:79:8: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   void beginJob();
       ^

HLTriggerOffline/Egamma/interface/EmDQM.h:80:8: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   void endJob();
       ^

HLTriggerOffline/Exotica/interface/HLTExoticaValidator.h:49:18: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
     virtual void beginJob();
                 ^

HLTriggerOffline/Exotica/interface/HLTExoticaValidator.h:55:18: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
     virtual void endJob();
                 ^
@gartung
Copy link
Member Author

gartung commented Mar 6, 2018

@Dr15Jones

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

The code-checks are being triggered in jenkins.

HLTriggerOffline/Muon/src/HLTMuonValidator.cc:51:16: warning: 'beginJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   virtual void beginJob();
               ^

HLTriggerOffline/Muon/src/HLTMuonValidator.cc:56:16: warning: 'endJob' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   virtual void endJob();
               ^
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

HLTriggerOffline/Egamma
HLTriggerOffline/Exotica

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@mtosi this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26615/console Started: 2018/03/06 23:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22501/26615/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1032
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2477813
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1558.82 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2018

Differences in tests come from the unrelated FastSim fix.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2018

+1

@cmsbuild cmsbuild merged commit 4e7968a into cms-sw:master Mar 8, 2018
@gartung gartung deleted the HLTriggerOffline-cleanup-clang-warnings branch March 9, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants