Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of labels for superclusterfbrem histograms in Validation/RecoEgamma #22526

Merged
merged 1 commit into from Mar 9, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Mar 8, 2018

Forward port of #22195 already integrated in 10_0_X (erroneously before integration in master).

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Validation/RecoEgamma

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26696/console Started: 2018/03/08 14:15

@fabiocos fabiocos changed the title Change of labels for superclusterfbrem histograms as in PR 22195 Change of labels for superclusterfbrem histograms in Validation/RecoEgamma Mar 8, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

-1

Tested at: c980507

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22526/26696/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2018

the crash looks due to a problem in file access unrelated with the (minimal) change, retry

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26721/console Started: 2018/03/08 23:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22526/26721/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2484711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2484534
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.05999999998 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 9, 2018

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 9, 2018

@dmitrijus you have already signed this change for 10_0_X, so I assume you have no comment

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 9, 2018

merge

@cmsbuild cmsbuild merged commit 225ca50 into cms-sw:master Mar 9, 2018
@fabiocos fabiocos deleted the fc-recoegammav branch March 26, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants