RecoLocalTracker/SiStripRecHitConverter: Fix bug found by clang warningand fix clang warnings:

[gartung]

Loop counter not incremented in body.

src/RecoLocalTracker/SiStripRecHitConverter/src/SiStripTemplate.cc:555:16: warning: variable 'l' used in loop condition not modified in loop body [-Wfor-loop-analysis]
for (l=0; l<TSXSIZE; ++k) {db >> theCurrentTemp.entx[k][i].xtemp[j][l]; qavg_avg += theCurrentTemp.entx[k][i].xtemp[j][l];}

Warnings:

RecoLocalTracker/SiStripRecHitConverter/interface/StripCPEgeometric.h:13:5: warning: 'StripCPEgeometric::localParameters' hides overloaded virtual functions [-Woverloaded-virtual]
localParameters( const SiStripCluster&, const GeomDetUnit&, const LocalTrajectoryParameters&) const override;
^

src/RecoLocalTracker/SiStripRecHitConverter/interface/StripCPEfromTemplate.h:17:5: warning: 'StripCPEfromTemplate::localParameters' hides overloaded virtual functions [-Woverloaded-virtual]
localParameters( const SiStripCluster&, const GeomDetUnit&, const LocalTrajectoryParameters&) const override;
^

[cmsbuild]

The code-checks are being triggered in jenkins.

[gartung]

@Dr15Jones

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22533/3850

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26712/console Started: 2018/03/08 22:21

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @OlivierBondu, @mmusich, @threus, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 5d8fc0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22533/26712/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22533/26712/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2484711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2484534
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.09999999997 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[perrotta]

This fix, while due, seems to possible affect the normal workflow of the code: when k was (erroneously) incremented, the wrong k entered the following checks inside the outer loop
@OlivierBondu : whenever there are no issues with what stored in the the db probably the previous bug didn't show up, Do you expect situations in which there is any effect of this fix? Where should we look at to possibly see one?

[VinInn]

there is NOT such a thing as a StripTemplate in the database....

[perrotta]

Do you mean that this part of the code was never hit, and therefore while the fix is due we cannot see any effect out of it?

[makortel]

Naively thought the effect of the bug should be an infinite loop (likely leading to a segfault at some point).

[perrotta]

Indeed... That's correct @makortel: this demonstrates that this code was never run!

[pieterdavid]

I had a quick look, and it seems there are two reasons why this did not give problems:

• the template CPE is not used for the strips (StripCPEfromTrackAngle is the default), and the template cfi is only imported in some outdated test configs
• there is no code in CMSSW that calls this method (the template CPE uses the one defined above, bool SiStripTemplate::pushfile(int filenum, std::vector< SiStripTemplateStore > & theStripTemp_)) - I verified by removing it and recompiling (after git cms-checkdeps -a), which showed no problems.

According to git this has not been touched since the migration from CVS. I think it has been copied/adapted from the corresponding code for the pixel detector here at some point.
Question (also to @mmusich @echabert @boudoul ): since this is not used (and apparently never has been), and it can be revived from git history or the pixel version in case it is needed some day, should we just remove this method?

[mmusich]

Hello, @pieterdavid, @perrotta,
as you correctly point out Strip template reconstruction was never developed (same people working on the pixel one were involved here) up to a point where it could be used in production and certainly we don't even have CondFormat to be able to store in DB. While we need to support the fromTrackAngle and, up to a certain degree the geometric CPE algorithm, I personally see no reason to keep in repository the template code at all if all it does is to create maintenance overhead.

[boudoul]

I second @mmusich 's comment

[perrotta]

@pieterdavid @mmusich @echabert @boudoul: will any of you take care of preparing a PR which removes from the release whatever is not used (in this package)? Thanks!

[pieterdavid]

Thanks @mmusich and @boudoul , I was only talking about this specific method, but I'm not against removing it completely either... @perrotta : submitted as #22546

[perrotta]

+1

• Technical
• It also includes a bug fix in a part of the code that was never run
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1