Commits on Mar 8, 2018

1. RecoLocalTracker/SiStripRecHitConverter: Fix bug found by clang warni… …

   …ng unincremented loop counter and fix clang warnings:
   
   src/RecoLocalTracker/SiStripRecHitConverter/src/StripCPE.cc
   /build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/llvm/5.0.0-ocgmcn/bin/clang++ -c -DGNU_GCC -D_GNU_SOURCE -DCMSSW_GIT_HASH='CMSSW_10_1_CLANG_X_2018-03-07-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_10_1_CLANG_X_2018-03-07-2300' -DTBB_USE_GLIBCXX_VERSION=60300 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -I/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/81541827a6a1dcc2a8e68c83e751c3d9/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-07-2300/src -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/lcg/root/6.10.09-omkpbe3/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/boost/1.63.0-ocgmcn/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/pcre/8.37-oenich/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/bz2lib/1.0.6/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/clhep/2.4.0.0-ocgmcn/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/gsl/2.2.1/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/libuuid/2.22.2/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/python/2.7.11-ocgmcn/include/python2.7 -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/tbb/2018_U1/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/cms/vdt/0.4.0/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/xerces-c/3.1.3/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/xz/5.2.2-oenich/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/zlib-x86_64/1.2.11/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/md5/1.0.0/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/tinyxml/2.5.3-ocgmcn/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=uninitialized -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -DBOOST_DISABLE_ASSERTS -Wno-error=unused-variable -Wno-error=unused-variable -Wno-error=unused-variable   -fPIC      -MMD -MF tmp/slc6_amd64_gcc630/src/RecoLocalTracker/SiStripRecHitConverter/src/RecoLocalTrackerSiStripRecHitConverter/StripCPE.d /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/81541827a6a1dcc2a8e68c83e751c3d9/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-07-2300/src/RecoLocalTracker/SiStripRecHitConverter/src/StripCPE.cc -o tmp/slc6_amd64_gcc630/src/RecoLocalTracker/SiStripRecHitConverter/src/RecoLocalTrackerSiStripRecHitConverter/StripCPE.o
     /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/81541827a6a1dcc2a8e68c83e751c3d9/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-07-2300/src/RecoLocalTracker/SiStripRecHitConverter/src/SiStripTemplate.cc:555:16: warning: variable 'l' used in loop condition not modified in loop body [-Wfor-loop-analysis]
                                            for (l=0; l<TSXSIZE; ++k) {db >> theCurrentTemp.entx[k][i].xtemp[j][l]; qavg_avg += theCurrentTemp.entx[k][i].xtemp[j][l];}
   
   RecoLocalTracker/SiStripRecHitConverter/interface/StripCPEgeometric.h:13:5: warning: 'StripCPEgeometric::localParameters' hides overloaded virtual functions [-Woverloaded-virtual]
        localParameters( const SiStripCluster&, const GeomDetUnit&, const LocalTrajectoryParameters&) const override;
       ^
   
   src/RecoLocalTracker/SiStripRecHitConverter/interface/StripCPEfromTemplate.h:17:5: warning: 'StripCPEfromTemplate::localParameters' hides overloaded virtual functions [-Woverloaded-virtual]
        localParameters( const SiStripCluster&, const GeomDetUnit&, const LocalTrajectoryParameters&) const override;
       ^

   

   gartung committed Mar 8, 2018
   Copy the full SHA

   5d8fc0a View commit details

   Browse the repository at this point in the history