Run2-hgx102 Transfer the hash for DetId in DetId.h

[bsunanda]

The same hash was declared in many places. For more economic use of unsorted_set it is now put in DetId.h

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22537/3856

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/DetId
RecoEgamma/EgammaPhotonProducers
SimCalorimetry/HGCalSimProducers
SimFastTiming/FastTimingCommon

@perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@vandreev11, @Sam-Harper, @sethzenz, @jainshilpi, @rovere, @lgray, @cseez, @pfs, @varuns23, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26719/console Started: 2018/03/08 22:45

[cmsbuild]

-1

Tested at: bec824b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22537/26719/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test EcalIntercalib_update_test had ERRORS

[cmsbuild]

Comparison job queued.

[kpedro88]

unit test failure not caused by this PR, seems to be failing in IBs also

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22537/26719/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2484711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2484534
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.12999999994 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

@kpedro88 the unit test failure is unrelated to this PR

[kpedro88]

+1

[bsunanda]

The failure in the unit test has nothing to do with this PR. There was one unrelated file was missing: "Generating popcon record for run 311352...going to open file Intercalib_Boff.xmlERROR : cannot open file Intercalib_Boff.xml"

[perrotta]

please test
(Unit test error is unrelated, and fixed by #22505, merged since CMSSW_10_1_X_2018-03-11-0000: let re-launch the tests with the fix merged in the baseline)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26776/console Started: 2018/03/11 23:26

[cmsbuild]

+1
Tested at: bec824b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22537/26776/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22537/26776/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2477919
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477742
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.97999999988 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[civanch]

+1

[slava77]

+1

for #22537 bec824b

• implementation is in line with the description; the change is technical
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

useful for upgrade, no effect on RecoEgamma