Fix for Ecal O2O test

[ggovi]

Removed execution of EcalIntercalib_update_test since it requires specific input file

[cmsbuild]

The code-checks are being triggered in jenkins.

[ggovi]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22505/3798

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26634/console Started: 2018/03/07 10:22

[cmsbuild]

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

@ggovi as far as I understand this is not solving the issue, just hiding it, right? Isn't this file available? I understand we are missing the test for a possible operation workflow in this way.

[cmsbuild]

+1
Tested at: f6df593
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22505/26634/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22505/26634/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2480211
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2480034
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.619999999893 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[ggovi]

@fabiocos
yes, I expect the Ecal experts ( @depasse ) will comment and hopefully fix this

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[depasse]

Hi, I don't know what you want I comment. If this must be suppressed, suppress it..

…

________________________________ From: ggovi [notifications@github.com] Sent: 07 March 2018 16:33 To: cms-sw/cmssw Cc: Pierre Depasse; Mention Subject: Re: [cms-sw/cmssw] Fix for Ecal O2O test (#22505) @fabiocos<https://github.com/fabiocos> yes, I expect the Ecal experts ( @depasse<https://github.com/depasse> ) will comment and hopefully fix this — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22505 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEaCW6RjXxpqiaWbGjIpEJWg5_YTnpUEks5tb_3GgaJpZM4SgG1R>.

[ggovi]

@depasse
The comment we expect concern the possibility to have this test working, since it requires an xml input file to behave properly. I guess you know what input file it expects.
Obviously we have the option to suppress it, but this will leave this workflow untested - as commented by Fabio.

[depasse]

The xml files are the dumps of ADCToGeV and Intercalib tags (like the Bon/Boff....xml you suppressed online). There is no workflow. As already said, it is used only to create a sqlite file from a xml file. I can keep it private if needed.

…

________________________________ From: ggovi [notifications@github.com] Sent: 07 March 2018 17:04 To: cms-sw/cmssw Cc: Pierre Depasse; Mention Subject: Re: [cms-sw/cmssw] Fix for Ecal O2O test (#22505) @depasse<https://github.com/depasse> The comment we expect concern the possibility to have this test working, since it requires an xml input file to behave properly. I guess you know what input file it expects. Obviously we have the option to suppress it, but this will leave this workflow untested - as commented by Fabio. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22505 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEaCW-IrBPsbyeFzq9tKGSWRr6zYvTr9ks5tcAUggaJpZM4SgG1R>.

[ggovi]

@depasse we had already this discussion on a private thread. There 2 possibilities:

1. The command is calling CMSSW software that is no longer used
2. The command involves CMSSW software that is used to produce payloads for production.
   In case 1, we can happily drop the test. In case 2, we need a test exercising the corresponding code. As you may have noticed, I've added a test for all the part of the Ecal online code that I know is involved in the O2O. To my understanding, this one is used to produce the payload for the InterCalib tags. If this is the case, can you please make the concerned test working, since I'm unable, given that I'm not an Ecal experts. Hope this clarifies.

[jeanfay]

The proposition 1 from Giacomo is true :
The command is calling CMSSW software that is no longer used
We will upload a new version EcalIntercalibHandler.cc which reflects this fact

[ggovi]

@fabiocos
ok I think this can be merged, the failing test is no longer required

[fabiocos]

@ggovi @jeanfay if the code is obsolete I agree. But it would be good to get rid of obsolete unused code, that just makes maintenance cumbersome in a useless way.

[fabiocos]

+1