Pr101x L1T Kalman Filter BMTF emulator and DataFormat

[rekovic]

New L1T Kalman Filter Muon algorithm in BMTF.

Emulator packated in L1Trigger/L1TMuonBarrel.

New DataFormats

• L1MuKBMTCombinedStub
  • Made of TwinMux eta and phi segments
• L1MuKBMTrack
  • for KalmanFilter Track Finder

Updated DataFormats

• RegionalMuonCand (update)
  • addition of a second hwPt and a hwDXY in the-> zero values by default for OMTF/EMTF
  • DataFormat is needed for the unpacker development as we are going to take data with
    this algo in the firmware

Note:
To run include simKBmtfStubs*simKBmtfDigis in EmuL1Simulation sequence.
As is should not have any effect.

[rekovic]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22542/3865

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22542/3865/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22542/3865/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[rekovic]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22542/3866

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26724/console Started: 2018/03/09 06:56

[cmsbuild]

A new Pull Request was created by @rekovic for master.

It involves the following packages:

DataFormats/L1TMuon
L1Trigger/L1TMuonBarrel

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 767a8ef

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22542/26724/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

        ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-08-2300/src/L1Trigger/L1TMuonBarrel/interface/L1TMuonBarrelKalmanLUTs.h:2:9: note: '__L1TMuonBarrelKalmanLUTs_h' is defined here; did you mean '__L1TMuonBarelKalmanLUTs_h'?
#define __L1TMuonBarrelKalmanLUTs_h
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        __L1TMuonBarelKalmanLUTs_h
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-08-2300/src/L1Trigger/L1TMuonBarrel/src/L1TMuonBarrelKalmanAlgo.cc:736:29: error: comparison of integers of different signs: 'int' and 'uint' (aka 'unsigned int') [-Werror,-Wsign-compare]
        if (abs(track.approxChi2())>globalChi2Cut_)
            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-08-2300/src/L1Trigger/L1TMuonBarrel/src/L1TMuonBarrelKalmanAlgo.cc:777:14: warning: taking the absolute value of unsigned type 'uint' (aka 'unsigned int') has no effect [-Wabsolute-value]
     chi=chi+abs(delta);    
             ^


[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22542/3925

[cmsbuild]

Pull request #22542 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26808/console Started: 2018/03/13 11:12

[cmsbuild]

+1
Tested at: 6d6c533
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22542/26808/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22542/26808/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2477528
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477351
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.06 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

needed for commissioning DQM, no effect in standard workflows