Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in Online Tracking for Pixels #22555

Merged
merged 1 commit into from Mar 22, 2018
Merged

Fix crash in Online Tracking for Pixels #22555

merged 1 commit into from Mar 22, 2018

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Mar 9, 2018

This PR fixes a crash in the online pixel client, it is based on 10_0_3 as requested by the DQM team.
It will be submitted later in 10_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

A new Pull Request was created by @fioriNTU for CMSSW_10_0_X.

It involves the following packages:

DQM/Integration
DQM/SiPixelPhase1Config

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@batinkov, @hdelanno, @makortel, @thomreis, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

Why is it so different from 10_1_X?

@fioriNTU
Copy link
Contributor Author

@dmitrijus, because in 10_0_X another PR was already merged in the IB (#22336), so I had to workaround it.

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26817/console Started: 2018/03/13 15:11

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22555/26817/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468519
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468349
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.08000000005 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 49ecedc into cms-sw:CMSSW_10_0_X Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants