Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete migration from physics tools - cmssw93X #22588

Conversation

perrotta
Copy link
Contributor

93X version of #22584 (where also the code-checks fixes have been included): the fix is needed for the production of Phase2 MC

As pointed out in the issue #22483 , nearly all classes "migrated" by 60bfee7 have still a copy in PhysicsTools/CandUtils

Code in CMSSW accessed either one or the other implementation, with the same name and often also with the definition in the interface protected by an identical include guard

This PR removes all the duplicate implementations that were left in PhysicsTools/CandUtils, and adapts the classes that still relied on them to use the same (identical) implementations that were migrated longtime ago in CommonTools/CandUtils

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2018

A new Pull Request was created by @perrotta for CMSSW_9_3_X.

It involves the following packages:

ElectroWeakAnalysis/ZEE
HLTrigger/JetMET
HeavyFlavorAnalysis/RecoDecay
PhysicsTools/CandUtils
PhysicsTools/HepMCCandAlgos
PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
TopQuarkAnalysis/TopPairBSM

@perrotta, @cmsbuild, @silviodonato, @fwyzard, @monttj, @Martin-Grunewald, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @TaiSakuma, @gouskos, @kreczko, @imarches, @ahinzmann, @rappoccio, @acaudron, @gpetruc, @mmarionncern, @jdolen, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Mar 13, 2018

backport of #22584

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26804/console Started: 2018/03/13 09:49

@perrotta perrotta changed the title Complete migration from physics tools cmssw93 x Complete migration from physics tools - cmssw93X Mar 13, 2018
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22588/26804/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 235
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624036
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@perrotta
Copy link
Contributor Author

+1

  • 93X backport of Complete the migration from PhysicsTools/CandUtils #22584, now merged in the master
  • Duplicated classes in PhysicsTools/CandUtils are been removed, and all code in CMSSW that still accessed them gets modified accordingly
  • No effect is expected in reco outputs, none is observed in jenkins tests

@kpedro88
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1f6c571 into cms-sw:CMSSW_9_3_X Mar 19, 2018
@perrotta perrotta deleted the completeMigrationFromPhysicsTools_CMSSW93X branch February 17, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants