New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete migration from physics tools - cmssw93X #22588
Complete migration from physics tools - cmssw93X #22588
Conversation
A new Pull Request was created by @perrotta for CMSSW_9_3_X. It involves the following packages: ElectroWeakAnalysis/ZEE @perrotta, @cmsbuild, @silviodonato, @fwyzard, @monttj, @Martin-Grunewald, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #22584 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
+1
|
merge |
93X version of #22584 (where also the code-checks fixes have been included): the fix is needed for the production of Phase2 MC
As pointed out in the issue #22483 , nearly all classes "migrated" by 60bfee7 have still a copy in PhysicsTools/CandUtils
Code in CMSSW accessed either one or the other implementation, with the same name and often also with the definition in the interface protected by an identical include guard
This PR removes all the duplicate implementations that were left in PhysicsTools/CandUtils, and adapts the classes that still relied on them to use the same (identical) implementations that were migrated longtime ago in CommonTools/CandUtils