Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calo particle validation with graph #22596

Merged
merged 28 commits into from Apr 3, 2018

Commits on Mar 13, 2018

  1. Add CaloParticle Debug package

    Actually the debug package contains also a complete reimplementation of
    the CaloParticle logic fully based on the BGL that greatly simplify the
    extremely complex logic of the currently used CaloTruthAccumulator. The
    implementation is not yet final but gives already identical results if
    compared with the regularly produced CaloParticles.
    rovere committed Mar 13, 2018
    Copy the full SHA
    8a1ec7e View commit details
    Browse the repository at this point in the history
  2. Minor stylistic changes

    Full recursion and creation of CaloParticles.
    rovere committed Mar 13, 2018
    Copy the full SHA
    d263af2 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    6c5f05e View commit details
    Browse the repository at this point in the history
  4. Cleanup unused structures

    rovere committed Mar 13, 2018
    Copy the full SHA
    d2e1c22 View commit details
    Browse the repository at this point in the history
  5. More code cleanup

    rovere committed Mar 13, 2018
    Copy the full SHA
    66b57e8 View commit details
    Browse the repository at this point in the history
  6. Code reformatting with clang

    rovere committed Mar 13, 2018
    Copy the full SHA
    fbdd6bf View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    b97765b View commit details
    Browse the repository at this point in the history
  8. Final version

    rovere committed Mar 13, 2018
    Copy the full SHA
    73b8869 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    f8db957 View commit details
    Browse the repository at this point in the history
  10. Merge header into cc file

    rovere committed Mar 13, 2018
    Copy the full SHA
    d2950d3 View commit details
    Browse the repository at this point in the history
  11. Simplify the Debugging plugin

    rovere committed Mar 13, 2018
    Copy the full SHA
    77836a5 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    6a80062 View commit details
    Browse the repository at this point in the history
  13. Remove unnecessary cfi file

    rovere committed Mar 13, 2018
    Copy the full SHA
    b573803 View commit details
    Browse the repository at this point in the history
  14. Use meaningful filenames

    rovere committed Mar 13, 2018
    Copy the full SHA
    13a77cf View commit details
    Browse the repository at this point in the history
  15. Address some review comments

    rovere committed Mar 13, 2018
    Copy the full SHA
    b91785a View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    59e3314 View commit details
    Browse the repository at this point in the history
  17. Fix GCC flags and dot output

    rovere committed Mar 13, 2018
    Copy the full SHA
    0e15c13 View commit details
    Browse the repository at this point in the history
  18. Copy the full SHA
    89857cb View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    5b394a8 View commit details
    Browse the repository at this point in the history
  20. Copy the full SHA
    5c9cf9d View commit details
    Browse the repository at this point in the history
  21. Debug also SimClusters

    rovere committed Mar 13, 2018
    Copy the full SHA
    c853c2a View commit details
    Browse the repository at this point in the history
  22. Improve CaloParticle Validation

    Add more histograms to monitor CaloParticles and monitor more kind of
    particles based on their pdgId.
    rovere committed Mar 13, 2018
    Copy the full SHA
    2e157bc View commit details
    Browse the repository at this point in the history
  23. Add more CaloParticles

    Few particles  are linked still to vertex 0 but are separate from the
    main vertex graph. This will recover them and promote them to be
    CaloParticles if them or any of their children leave hits in the
    configured calorimeters.
    rovere committed Mar 13, 2018
    Copy the full SHA
    fd504b2 View commit details
    Browse the repository at this point in the history
  24. Recover CaloParticle into SimPFProducer

    Every CaloParticle is linked to the first stable particle originating
    the cascade of particles that left hits in the calorimeters: that
    stable particle is not included as a simCluster (unless it itself left
    hits in the calorimiters). Additional code has been added to find a
    matching track based on the trackId linked to the CaloParticle itself,
    not to the associated simClusters. The most important clients affected
    by this change are electrons.
    rovere committed Mar 13, 2018
    Copy the full SHA
    d759937 View commit details
    Browse the repository at this point in the history
  25. Copy the full SHA
    506b3a4 View commit details
    Browse the repository at this point in the history
  26. Apply code-checks

    rovere committed Mar 13, 2018
    Copy the full SHA
    59c4c11 View commit details
    Browse the repository at this point in the history
  27. Remove unused dependency

    rovere committed Mar 13, 2018
    Copy the full SHA
    1bd7e49 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Implement Review comments 1

    rovere committed Mar 14, 2018
    Copy the full SHA
    8b0ab5c View commit details
    Browse the repository at this point in the history