New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calo particle validation with graph #22596
Merged
cmsbuild
merged 28 commits into
cms-sw:master
from
rovere:CaloParticleValidationWithGraph
Apr 3, 2018
Merged
Calo particle validation with graph #22596
cmsbuild
merged 28 commits into
cms-sw:master
from
rovere:CaloParticleValidationWithGraph
Apr 3, 2018
Commits on Mar 13, 2018
-
Add CaloParticle Debug package
Actually the debug package contains also a complete reimplementation of the CaloParticle logic fully based on the BGL that greatly simplify the extremely complex logic of the currently used CaloTruthAccumulator. The implementation is not yet final but gives already identical results if compared with the regularly produced CaloParticles.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Improve CaloParticle Validation
Add more histograms to monitor CaloParticles and monitor more kind of particles based on their pdgId.
-
Few particles are linked still to vertex 0 but are separate from the main vertex graph. This will recover them and promote them to be CaloParticles if them or any of their children leave hits in the configured calorimeters.
-
Recover CaloParticle into SimPFProducer
Every CaloParticle is linked to the first stable particle originating the cascade of particles that left hits in the calorimeters: that stable particle is not included as a simCluster (unless it itself left hits in the calorimiters). Additional code has been added to find a matching track based on the trackId linked to the CaloParticle itself, not to the associated simClusters. The most important clients affected by this change are electrons.
-
-
-
Commits on Mar 14, 2018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.