New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TensorFlow interface for TF 1.6. #22603
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22603/3943 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22603/3943/git-diff.patch You can run |
please test with #22568 cms-sw/cmsdist#3835 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @riga (Marcel R.) for master. It involves the following packages: PhysicsTools/TensorFlow @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 for #22603 ef5a03c
|
@fabiocos , can we get this PR + #22568 cms-sw/cmsdist#3835 ? |
@fabiocos |
please test with #22568 cms-sw/cmsdist#3835 |
@smuzaffar I would prefer to wait 10_2_X for this |
@fabiocos , can we get this and external in 10.2.X now? |
+1 |
merge |
This PR updates the custom NTSession and TBBSession implementations in PhysicsTools/TensorFlow to work with TensorFlow 1.6. As before, changes w.r.t. upstream code are minimized in order to simplify future updates.
Upstream changes can be found here: tensorflow/tensorflow@v1.5.0...v1.6.0
The switch to TF 1.6 was proposed in #22568 (comment), the associated PR in cmsdist is cms-sw/cmsdist#3835.