Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TensorFlow interface for TF 1.6. #22603

Merged
merged 1 commit into from Apr 3, 2018
Merged

Conversation

riga
Copy link
Contributor

@riga riga commented Mar 14, 2018

This PR updates the custom NTSession and TBBSession implementations in PhysicsTools/TensorFlow to work with TensorFlow 1.6. As before, changes w.r.t. upstream code are minimized in order to simplify future updates.

Upstream changes can be found here: tensorflow/tensorflow@v1.5.0...v1.6.0

The switch to TF 1.6 was proposed in #22568 (comment), the associated PR in cmsdist is cms-sw/cmsdist#3835.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2018

+code-checks
explicitly set code checks passed (by @smuzaffar)

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22603/3943

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22603/3943/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22603/3943/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@smuzaffar
Copy link
Contributor

please test with #22568 cms-sw/cmsdist#3835

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3835
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26841/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @riga (Marcel R.) for master.

It involves the following packages:

PhysicsTools/TensorFlow

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22603/26841/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2477528
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2477351
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.5700000002 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@smuzaffar
Copy link
Contributor

@fabiocos , can we get this PR + #22568 cms-sw/cmsdist#3835 ?

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2018

@fabiocos
please clarify if this can make it to the master/10_1_X or if it should wait for 10_2_X to open
Thank you.

@cmsbot
Copy link

cmsbot commented Mar 21, 2018

please test with #22568 cms-sw/cmsdist#3835
testing updates for the external

@fabiocos
Copy link
Contributor

@smuzaffar I would prefer to wait 10_2_X for this

@smuzaffar smuzaffar modified the milestones: CMSSW_10_1_X, CMSSW_10_2_X Mar 29, 2018
@smuzaffar
Copy link
Contributor

@fabiocos , can we get this and external in 10.2.X now?

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2018

merge

@cmsbuild cmsbuild merged commit 0d66b8b into cms-sw:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants