Run2-alca121 Take care of HLT codes for IsoTrackHB/HE in view of increased noise level in EE

[bsunanda]

Thresholds are separately handed for EB and EE (also use eta dependent threshold for EE)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22621/3966

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalIsolatedTrackReco
HLTrigger/special

@ghellwig, @cmsbuild, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @lpernie can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26859/console Started: 2018/03/14 22:13

[cmsbuild]

-1

Tested at: 5e2e1fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22621/26859/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

• AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02515/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_1_X_2018-03-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 14 23:20:42 2018-date Wed Mar 14 23:09:39 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed Mar 14 23:20:42 2018-date Wed Mar 14 23:09:39 2018 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02515/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_1_X_2018-03-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Mar 14 23:17:20 2018-date Wed Mar 14 23:10:20 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Mar 14 23:17:20 2018-date Wed Mar 14 23:10:20 2018 s - exit: 18688

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[Martin-Grunewald]

It seems IsolatedEcalPixelTrackCandidateProducer is missing a fillDescriptions method which would take care of the new parameters not yet present in the HLT configuration (and the old parameters should be set as deprecated in there).
Likewise for HLTEcalPixelIsolTrackFilter in that you should keep the old parameters in fillDescriptions (until the HLT menu is updated).

[bsunanda]

@cmsbuild Please test

[cmsbuild]

Pull request #22621 was updated. @ghellwig, @cmsbuild, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @lpernie can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26978/console Started: 2018/03/20 12:03

[cmsbuild]

+1
Tested at: 2b376da
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22621/26978/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22621/26978/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2497880
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497703
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.08000000004 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[bsunanda]

@Martin-Grunewald @lpernie @arunhep Can you approve this PR?

[Martin-Grunewald]

+1

[bsunanda]

@lpernie @arunhep @ghellwig This PR is needed for the HLT menu of 10_1_0. Could you please approve this?

[bsunanda]

@lpernie Could you please approve this as well?

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1