Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JECs update for AK4PF, AK8PF, and AK8PFchs #22638

Merged
merged 1 commit into from Mar 16, 2018

Conversation

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arunhep (Arun Kumar) for CMSSW_9_4_MAOD_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor Author

arunhep commented Mar 15, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26899/console Started: 2018/03/15 22:38

@arunhep
Copy link
Contributor Author

arunhep commented Mar 15, 2018

@fabiocos this is last minute update for MC GT for 2017 miniAOD V2.
It will be good to include it whenever the release for miniAOD v2 will be built.
Thanks a lot.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22638/26899/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 704
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2720627
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 110 log files, 9 edm output root files, 27 DQM output files

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@arunhep @franzoni I understand that these are the JECs presented in https://indico.cern.ch/event/709771/contributions/2916153/attachments/1613813/2563659/2018_03_08_PPD_JERC2017.pdf
that have to be used for the 94X reminiAODv2
Do we have a master branch version of it?

@fabiocos fabiocos mentioned this pull request Mar 16, 2018
15 tasks
@arunhep
Copy link
Contributor Author

arunhep commented Mar 16, 2018

@fabiocos I am opening a grand PR containing these as well as other important updates for master.
In the middle of creating all the GTs.

@fabiocos
Copy link
Contributor

@arunhep sorry, how much "grand"? Would not be better to converge on this move for 94X and proceed with its validation? I assume other things are for 2018 and are unrelated, right?

@arunhep
Copy link
Contributor Author

arunhep commented Mar 16, 2018

@fabiocos "grand" in the sense of updating all the GTs (27 of them) with hadronic PF calibrations as well as including GEM electronics map for all GTs from 2017, 2018 and postLS2 and Phase2.
These JECs will only enter 2017 MC GTs.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2207434 into cms-sw:CMSSW_9_4_MAOD_X Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants