Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move edmStreamStallGrapher.py from bin to scripts so that it gets found automatically from $PATH #22640

Merged
merged 1 commit into from Mar 19, 2018

Conversation

makortel
Copy link
Contributor

Title says it all.

Tested in CMSSW_10_1_X_2018-03-15-2300, no changes expected.

@Dr15Jones @wddgit

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26903/console Started: 2018/03/16 11:08

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Tested at: 3c895b1

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d19a033
06dde77
767c579
19c3d8d
beb4bef
f0b49cd
a687825
854267e
e589052
cf7c57b
17419b8
d4b1947
b11093b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22640/26903/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22640/26903/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22640/26903/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling python modules src/DQM/HcalCommon/python
>> Done generating edm plugin poisoned information
>> All python modules compiled
>> Plugins of all types refreshed.
gmake[1]: Leaving directory '/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-14-2300'
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d19a033
06dde77
767c579
19c3d8d
beb4bef
f0b49cd
a687825
854267e
e589052
cf7c57b
17419b8
d4b1947
b11093b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22640/26903/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22640/26903/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@Dr15Jones
Copy link
Contributor

The test failures have nothing to do with this pull request. They come from failures in the IB.

@fabiocos
Copy link
Contributor

+1

emd utility moved to another directory

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b72f115 into cms-sw:master Mar 19, 2018
cmsbuild added a commit that referenced this pull request Mar 20, 2018
adopted unit test accourding to the changes in #22640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants